Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] For incorrect name formats return a better error #4174

Closed
2 tasks done
Tracked by #4064
kumare3 opened this issue Oct 5, 2023 · 4 comments · Fixed by #4175
Closed
2 tasks done
Tracked by #4064

[BUG] For incorrect name formats return a better error #4174

kumare3 opened this issue Oct 5, 2023 · 4 comments · Fixed by #4175
Labels
bug Something isn't working hacktoberfest

Comments

@kumare3
Copy link
Contributor

kumare3 commented Oct 5, 2023

Describe the bug

pyflyte run --remote --name 078b0145-016a-44d8-bac0-fffa2e722f9c test2.py wf --n 10

returns

RPC Failed, with Status: StatusCode.INVALID_ARGUMENT
	details: invalid name format: 078b0145-016a-44d8-bac0-fffa2e722f9c
	Debug string UNKNOWN:Error received from peer ipv4:18.116.105.151:443 {grpc_message:"invalid name format: 078b0145-016a-44d8-bac0-fffa2e722f9c", grpc_status:3, created_time:"2023-10-04T23:18:28.696363-07:00"}

This is hard to understand the problem.

The reason is

return errors.NewFlyteAdminErrorf(codes.InvalidArgument, "invalid %s format: %s", fieldName, executionID)

returns just the failing field, it should return the expected regex

Expected behavior

invalid name format: 078b0145-016a-44d8-bac0-fffa2e722f9c, does not match regex '^[a-z][a-z\-0-9]*$'

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers hacktoberfest and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 5, 2023
@shakeel-3
Copy link

Hi @samhita-alla

I hope you're doing well! I came across this issue and I'm excited about the opportunity to contribute to Hacktoberfest. It looks like a great fit for my skills and interests.

I would love to work on this issue and make a meaningful contribution to the project. Could you please assign it to me, or provide guidance on how I can get started? I'm eager to collaborate with the team and ensure the issue is resolved effectively.

Thank you for your time, and I'm looking forward to being part of this project!

Best regards,
Mohd Shakeel

@samhita-alla
Copy link
Contributor

samhita-alla commented Oct 5, 2023

Looks like a PR has already been created.

@samhita-alla samhita-alla assigned shakeel-3 and unassigned shakeel-3 Oct 5, 2023
@shakeel-3
Copy link

@samhita-alla
Thank you for letting me know! I appreciate your prompt response. It's great to see that the issue has already been addressed with a pull request.

I'm glad to see the project is so active, and I'll keep an eye out for other opportunities to contribute. If there's anything specific that needs attention or any other way I can help, please feel free to let me know. I'm eager to get involved and contribute to this project.

Thanks again, and happy coding!

Best regards,
Mohd Shakeel

@iamakhileshmishra
Copy link

if this issue is still open i would like to contribute into this please assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants