Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] flytectl update un-archives objects when updating their properties without both --activate and --archive flags #4114

Closed
2 tasks done
Tracked by #4064
kamaleybov opened this issue Oct 2, 2023 · 3 comments
Assignees
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service hacktoberfest

Comments

@kamaleybov
Copy link
Contributor

kamaleybov commented Oct 2, 2023

Describe the bug

If an object is archived, and I update any property except state (e.g., description), the object is unarchived.

Here's an example with projects:

$ flytectl get project
 --------------- --------------- ---------------------------
| ID            | NAME          | DESCRIPTION               |
 --------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
 --------------- --------------- ---------------------------
| flytetester   | flytetester   | flytetester description   |
 --------------- --------------- ---------------------------
| flytesnacks   | woopidoo      | oops2                     |
 --------------- --------------- ---------------------------
3 rows

$ flytectl update project --id flytesnacks --archive
Project flytesnacks updated

$ flytectl get project
 --------------- --------------- ---------------------------
| ID            | NAME          | DESCRIPTION               |
 --------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
 --------------- --------------- ---------------------------
| flytetester   | flytetester   | flytetester description   |
 --------------- --------------- ---------------------------
2 rows

$ flytectl update project --id flytesnacks --description "bananas"
Project flytesnacks updated

$ flytectl get project
 --------------- --------------- ---------------------------
| ID            | NAME          | DESCRIPTION               |
 --------------- --------------- ---------------------------
| flyteexamples | flyteexamples | flyteexamples description |
 --------------- --------------- ---------------------------
| flytetester   | flytetester   | flytetester description   |
 --------------- --------------- ---------------------------
| flytesnacks   | woopidoo      | bananas                   |
 --------------- --------------- ---------------------------
3 rows

Expected behavior

Objects should stay in whatever state they were prior to update.

Additional context to reproduce

  1. Archive an object.
  2. Update any property except state (e.g., do not use --activate or --archive flags).
  3. Get the object and see that its state changed to active.

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kamaleybov kamaleybov added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 2, 2023
@pingsutw pingsutw added flyteadmin Issue for FlyteAdmin Service hacktoberfest and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 3, 2023
@soumya-dash3
Copy link

Hello @pingsutw , can you please assign me this issue?

@soumya-dash3
Copy link

Sorry for the inconvenience @pingsutw , you may assign this to someone else.

@mcanueste
Copy link
Contributor

Hi! I created a PR for fixing this bug here: flyteorg/flytectl#438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants