-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Allow dictionaries to be passed to execute workflows that take dataclasses #4098
Comments
Thank you for opening your first issue here! 🛠 |
I've roughly identified what would change to accommodate this (namely the |
@curlywurlycraig |
This is pretty much exactly what I had in mind for a solution yeah. Basically update the type checking in the dataclass transformer |
@K-Kumar-01 / @curlywurlycraig, are any of you working on creating a PR for this issue? |
I am not! |
I would like to work on this, can you assign me, please? |
I'm closing this issue because it was fixed in flyteorg/flytekit#2013 |
Motivation: Why do you think this is important?
When using flytekit to execute a workflow in Flyte, if the workflow takes a dataclass it is not always feasible to pass an instance of that same dataclass to flytekit (for example, if flytekit is being run from some location/project that does not have access to the dataclass defined in the same package that is used in the workflow).
Goal: What should the final outcome look like, ideally?
When calling
flytekit_client.execute
on a workflow that takes a dataclass, passing a plain dictionary with the same shape as the dataclass should execute successfully. For example:I should be able to call:
Describe alternatives you've considered
If a flyte workflow takes a dataclass as an input, the flyte type that comes back in the workflow interface is a dataclass, so the execution expects a dataclass as input. Otherwise the type engine attempts to read the input as a dataclass and fails.
Other possible solutions to this are:
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: