Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] tensorflow types: create flytesnacks example page #4065

Closed
2 tasks done
Tracked by #4064 ...
samhita-alla opened this issue Sep 25, 2023 · 10 comments · Fixed by #5807
Closed
2 tasks done
Tracked by #4064 ...

[Docs] tensorflow types: create flytesnacks example page #4065

samhita-alla opened this issue Sep 25, 2023 · 10 comments · Fixed by #5807
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3

Comments

@samhita-alla
Copy link
Contributor

samhita-alla commented Sep 25, 2023

Description

Add a page to the Data Types and IO section in the user guide that documents all available TensorFlow types and explains how they work.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@samhita-alla samhita-alla added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers hacktoberfest and removed untriaged This issues has not yet been looked at by the Maintainers labels Sep 25, 2023
@Smartmind12
Copy link
Contributor

Hey @samhita-alla Can i Work on this issue?

@Vishalk91-4
Copy link

@samhita-alla, can you please assign this issue to me

@Smartmind12
Copy link
Contributor

@samhita-alla, can you please assign this issue to me

Hey @Vishalk91-4 I am currently waiting for this issue to be assigned to me. Kindly take up another issue to work on!

@samhita-alla
Copy link
Contributor Author

@Smartmind12, are you working on creating a PR?

@Smartmind12
Copy link
Contributor

@Smartmind12, are you working on creating a PR?

Hey @samhita-alla i have been busy so i promise to complete it by tomorrow or max day after tomorrow!

@sumana-2705
Copy link
Contributor

@samhita-alla

Hello, I'd like to solve this issue. Can you please assign it to me?

@davidmirror-ops
Copy link
Contributor

@sumana-2705 Thanks, please let us know soon if you have questions.

@sumana-2705
Copy link
Contributor

@davidmirror-ops
I noticed that other pages in Data Types and IO section have references for example code snippet in Flytesnacks repo. Should I also create a new file named tensorflow_type.py in Flytesnacks repo. If this is the case, should I need to submit different PRs in 2 repositories?

@davidmirror-ops
Copy link
Contributor

@sumana-2705 right. The page should include an example and those live on the flytesnacks repo. Feel free to tag me for review on your PRs. Thanks!

@sumana-2705
Copy link
Contributor

sumana-2705 commented Oct 4, 2024

@davidmirror-ops I have opened pull requests in both flyte and flytesnacks repositories, please review and suggest me the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3
Projects
None yet
5 participants