Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flytectl Feature] flytectl demo cluster - configurable port number #3792

Closed
shekhar-kotekar opened this issue Jun 20, 2023 · 9 comments · Fixed by #5969
Closed

[Flytectl Feature] flytectl demo cluster - configurable port number #3792

shekhar-kotekar opened this issue Jun 20, 2023 · 9 comments · Fixed by #5969
Assignees

Comments

@shekhar-kotekar
Copy link

Problem Description:

flytectl demo start command fails with below error when a developer has Docker Desktop which allows us to have a Kubernetes local cluster. Kubernetes API server runs on port 6443. So we have to either turn off local Kubernetes cluster (not a good option) or allow demo cluster to use some other port.

{"status":"Status: Downloaded newer image for cr.flyte.org/flyteorg/flyte-sandbox-bundled:sha-1ae254f8683699b68ecddc89d775fc5d39cc3d84"}
🧑‍🏭 booting Flyte-sandbox container
😬 Something went wrong: Failed to start Sandbox container 🐋, Please check your docker client and try again. 
Error: Error response from daemon: driver failed programming external connectivity on endpoint flyte-sandbox (5eaf6609c86e6d818291e2f060e42f8002dfd4e288393da6e01109cfa5a60bd7): listen tcp4 0.0.0.0:6443: bind: address already in use

Requested feature:
Allow demo cluster to use other port preferrably via config file (config.yaml or config-sandbox.yaml or some other file) so that if a developer has some other container / process using the same port, they can change it and quickly get the demo cluster up and running.

Environment details:

  • Docker Desktop with Kubernetes enabled
  • Mac with M1 chip
  • Discussion about this issue on slack is here
flytectl version  
{
  "App": "flytectl",
  "Build": "0cb2bfa",
  "Version": "0.6.39",
  "BuildTime": "2023-06-20 14:45:22.664715 +0200 CEST m=+0.016518584"
}

@enricorotundo
Copy link

I do vote in favor of this feature request. Also, flytectl demo start seems to insist on serving on localhost while I'd need it to serve on 0.0.0.0, should that also be configurable?

@shekhar-kotekar
Copy link
Author

Hey @jeevb any luck with solving this issue? I can give a try to fix this.

@jeevb
Copy link
Contributor

jeevb commented Oct 9, 2023

Haven't had a chance to look into this yet. Please feel free to take a crack at it! 🙏

@Future-Outlier
Copy link
Member

Future-Outlier commented Oct 11, 2023

I can take a look at this feature and will tell you the result soon.

@Future-Outlier
Copy link
Member

I will create a PR today, I know how to do it.

@guyarad
Copy link
Contributor

guyarad commented Mar 3, 2024

@Future-Outlier was there a PR for this feature?

@Future-Outlier
Copy link
Member

@Future-Outlier was there a PR for this feature?

Nope, you can take it, thank you!

@Masame
Copy link

Masame commented Aug 21, 2024

Is there a workaround for this?

@rmadanykgw
Copy link

This issue seems to be starting when one updates docker / docker desktop version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants