Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adapt authentication flow for Azure AD #3620

Closed
2 tasks done
ByronHsu opened this issue Apr 26, 2023 · 0 comments
Closed
2 tasks done

[Feature] Adapt authentication flow for Azure AD #3620

ByronHsu opened this issue Apr 26, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ByronHsu
Copy link
Contributor

ByronHsu commented Apr 26, 2023

Describe the bug

We don't have good support for Azure AD auth flow.

  1. We lack documentation for the Azure AD setup
  2. Require several changes to fit into Azure AD.

Expected behavior

  1. Provide detailed steps to set up Azure AD
  2. User auth works properly with Azure AD

Planned Changes

  1. Azure AD setup doc
  2. Add oauth2 http proxy client to support on-prem use cases because their client usually doesn't have external network access.
  3. Fix bugs for deviceflow authenticator in flytekit
  4. Extract user's email from Azure AD claims in flyteadmin because the admin currently cannot parse email from Azure AD token

Additional context to reproduce

NA

Screenshots

NA

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ByronHsu ByronHsu added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Apr 26, 2023
@ByronHsu ByronHsu changed the title [BUG] Tailor the authentication flow to support AzureAD [BUG] Tailor the authentication flow to support Azure AD Apr 26, 2023
@ByronHsu ByronHsu changed the title [BUG] Tailor the authentication flow to support Azure AD [BUG] Adapt authentication flow for Azure AD Apr 27, 2023
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Apr 28, 2023
@ByronHsu ByronHsu changed the title [BUG] Adapt authentication flow for Azure AD [Feature] Adapt authentication flow for Azure AD May 11, 2023
@cosmicBboy cosmicBboy added enhancement New feature or request and removed bug Something isn't working labels May 11, 2023
@wild-endeavor wild-endeavor added this to the 1.7.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants