Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] homebrew formula unnecessarily depends on go #3406

Closed
2 tasks done
honnix opened this issue Mar 6, 2023 · 0 comments · Fixed by flyteorg/flytectl#395
Closed
2 tasks done

[BUG] homebrew formula unnecessarily depends on go #3406

honnix opened this issue Mar 6, 2023 · 0 comments · Fixed by flyteorg/flytectl#395
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@honnix
Copy link
Member

honnix commented Mar 6, 2023

Describe the bug

https://github.com/flyteorg/homebrew-tap/blob/24916be6c4001d1579385b350680ed99d93a6952/Formula/flytectl.rb#L10 this doesn't seem to be needed given we are pulling already built binary.

Expected behavior

brew install flyteorg/homebrew-tap/flytectl does not install go as the dependency.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 6, 2023
@honnix honnix mentioned this issue Mar 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove go as dependency of brew formula honnix/flytectl
1 participant
@honnix