Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlyteCTL Feature] Make default output of flytectl config init consistent with the demo sandbox config #3186

Closed
2 tasks done
cosmicBboy opened this issue Dec 23, 2022 · 5 comments · Fixed by #5947
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@cosmicBboy
Copy link
Contributor

Describe the feature/command for FlyteCTL

Currently, the output of flytectl config init is:

admin:
  # For GRPC endpoints you might want to use dns:///flyte.myexample.com
  endpoint: dns:///localhost:30081
  authType: Pkce
  insecure: true
logger:
  show-source: true
  level:

But the config produced by flytectl demo start is:

admin:
  # For GRPC endpoints you might want to use dns:///flyte.myexample.com
  endpoint: localhost:30080
  authType: Pkce
  insecure: true
console:
  endpoint: http://localhost:30080
logger:
  show-source: true
  level: 0

This may be confusing for new users who would expect the two configs to be consistent

Provide a possible output or UX example

The output of of flytectl config init should be the same as config-sandbox.yaml

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 23, 2022
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 20, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@eapolinario eapolinario added good first issue Good for newcomers and removed untriaged This issues has not yet been looked at by the Maintainers stale labels Dec 22, 2023
@Terryhung
Copy link
Contributor

#take

@Terryhung
Copy link
Contributor

After tracing the code, I found that config init can set up the console, but demo start cannot. Therefore, I plan to add the console in the Docker Config to align with initConfig.

@Terryhung
Copy link
Contributor

Terryhung commented Oct 25, 2024

config.yaml

admin:
  # For GRPC endpoints you might want to use dns:///flyte.myexample.com
  endpoint: dns:///localhost:30080
  insecure: true

config-sandbox.yaml

admin:
  # For GRPC endpoints you might want to use dns:///flyte.myexample.com
  endpoint: localhost:30080
  insecure: true
# This is not a needed configuration, only useful if you want to explore the data in sandbox. For non sandbox, please
# do not use this configuration, instead prefer to use aws, gcs, azure sessions. Flytekit, should use fsspec to
# auto select the right backend to pull data as long as the sessions are configured. For Sandbox, this is special, as
# minio is s3 compatible and we ship with minio in sandbox.
storage:
  connection:
    endpoint: http://localhost:30002
    access-key: minio
    secret-key: miniostorage

Next Step

  1. Remove storage
  2. refine http://localhost:30002 to dns:///localhost:30080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants