Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] protobuf lib Migratation #1931

Open
2 tasks done
yindia opened this issue Dec 10, 2021 · 4 comments
Open
2 tasks done

[Housekeeping] protobuf lib Migratation #1931

yindia opened this issue Dec 10, 2021 · 4 comments
Labels
enhancement New feature or request flyteidl housekeeping Issues that help maintain flyte and keep it tech-debt free needs discussion

Comments

@yindia
Copy link
Contributor

yindia commented Dec 10, 2021 •
edited
Loading

Describe the issue

Migrate Protobuf lib

What if we do not do this?

Not a P0 requirement

Related component(s)

flyteidl

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@yindia yindia added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Dec 10, 2021
@yindia yindia added this to the 1.0.0 - Phoenix! milestone Dec 10, 2021
@yindia yindia self-assigned this Dec 10, 2021
@yindia
Copy link
Contributor Author

yindia commented Dec 10, 2021

@kumare3 @EngHabu we talked about it earlier in slack, Let try to migrate it in v1.0.0

@kumare3
Copy link
Contributor

kumare3 commented Dec 10, 2021

@evalsocket would love that, but this is a mammoth task?

@katrogan
Copy link
Contributor

is there any way we can blacklist imports as part of PR checks so we make sure that after this change goes through we never accidentally re-introduce the gogo dep?

@yindia
Copy link
Contributor Author

yindia commented Dec 15, 2021 •
edited
Loading

@katrogan yes that's possible, We can add a workflow for testing each PR

@kumare3 yes i am aware about that, If it took time then we can plan for next release as per priority

@EngHabu EngHabu modified the milestones: 1.0.0 - Phoenix!, 1.0.1 Mar 9, 2022
@EngHabu EngHabu removed this from the 1.0.1 milestone May 4, 2022
@yindia yindia changed the title [Housekeeping] Migrate away from gogoprotobuf to protobuf v2 API + vtprotobuf [Housekeeping] protobuf lib Migratation May 6, 2022
@yindia yindia removed their assignment May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request flyteidl housekeeping Issues that help maintain flyte and keep it tech-debt free needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EngHabu @katrogan @yindia @kumare3