From dd27c18f02583d1c1f8c420841a42c8d02ad292c Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Tue, 11 Jul 2023 09:38:15 -0700 Subject: [PATCH] update doc Signed-off-by: Kevin Su --- rfc/system/0001-flyte-execution-tags.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rfc/system/0001-flyte-execution-tags.md b/rfc/system/0001-flyte-execution-tags.md index 48032a34d7..0ab42e1e90 100644 --- a/rfc/system/0001-flyte-execution-tags.md +++ b/rfc/system/0001-flyte-execution-tags.md @@ -31,9 +31,10 @@ As a User I want to ### Support for tags We propose to solve the problem of discovery by supporting arbitrary metadata association with an entity. This is similar to concept of “tags” as in AWS. -The tags are represented as plain string. In kubernetes this can be represented using “labels” and “annotations”. Labels and annotations are already supported per execution as documented in - [ExecutionCreateRequest](https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#executioncreaterequest) -> [ExecutionSpec](https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#executionspec). Moreover, every project supports default labels [Project](https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#project). Thus the final execution will have a the union of the project default labels + the user specified labels as it exists today. +The tags are represented as plain string. +We'll add tags to [ExecutionCreateRequest](https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#executioncreaterequest) -> [ExecutionSpec](https://docs.flyte.org/projects/flyteidl/en/latest/protos/docs/admin/admin.html#executionspec). -Currently, the resultant tags will be persisted in the database, instead of being applied to the +The resultant tags will be persisted in the database, instead of being applied to the execution in Kubernetes. We'll create two new tables in the flyteadmin database. - ``execution_admin_tags`` is a join table, and it contains admin_tags ID and execution ID. - ``admin_tags`` saves all the tag names