Calculate Bullet.app_root and IS_RUBY_19(former ruby_19?) once #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem::Version.new
andGem::Version#<=>
took more than half of all the execution time ofBullet::Detector::NPlusOneQuery.call_association
, andBullet.app_root
roughly 1/5 more. None of this is changed without the app restart, so it's safe to calculate them once.Before:
After:
Backstory: I was profiling an app with N+1s in it and realized that Bullet eats a lot of time, and
Gem::Version
takes most of it. After this patchcall_association
method time changed from 1300ms to 400ms.Last but not least, you are doing great job with this gem, I can't count how many times it helped me. Thank you!