fix: event_id_counter not being used in subscribe_to_system_event() #20
Conversation
msfs/src/sim_connect.rs
Outdated
| unsafe { | ||
| let system_event_name = std::ffi::CString::new(system_event_name).unwrap(); |
There was a problem hiding this comment.
Why did you move this inside the unsafe block?
There was a problem hiding this comment.
Because it's done this way in map_client_event_to_sim_event
There was a problem hiding this comment.
In my opinionen the less code in the unsafe block the better so could you move it out of there? Also in map_client_event_to_sim_event.
There was a problem hiding this comment.
Done. I did it for another function too.
|
You still need to fix the formatting. |
Which formatting? You mean the version? If yes, I've tried but I don't know how it works. |
I mean the formatting of the code (see failing check). |
I don't see the formatting problem, sorry. I thought it was related to the package version. Can you show me or fix it? Please |
juliansebline
changed the title
This PR fixes the issue #19