Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sec): ground spoiler logic improvements #7653

Merged
merged 3 commits into from
Dec 29, 2022
Merged

feat(sec): ground spoiler logic improvements #7653

merged 3 commits into from
Dec 29, 2022

Conversation

lukecologne
Copy link
Member

Summary of Changes

  • Fixes an issue with the ground spoiler full extension, where the spoilers would extend when only one thrust lever was at idle, instead of both.
  • Adds a condition to the partial extension, to reduce a possible bounce in the case of improper thrust handling on landing: The spoilers will partially extend when
    • The Ground Spoilers are armed
    • Both thrust levers are below the CLB notch
    • Both MLGs are compressed

Screenshots (if necessary)

References

https://safetyfirst.airbus.com/app/themes/mh_newsdesk/documents/archives/a320-family-evolution-of-ground-spoiler-logic.pdf

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@crocket63
Copy link
Contributor

Adding an entry in changelog maybe?

@lukecologne
Copy link
Member Author

Done

@lukecologne lukecologne force-pushed the gnd-splr-cond-fix branch 3 times, most recently from 6723210 to 1a05698 Compare December 21, 2022 18:52
@Saschl Saschl added the Exp Available on experimental branch (for testing) label Dec 22, 2022
Saschl added a commit that referenced this pull request Dec 22, 2022
@Saschl
feat(sec): ground spoiler logic improvements #7653 @1a05698
16c7544
beheh pushed a commit that referenced this pull request Dec 22, 2022
@Saschl @beheh
feat(sec): ground spoiler logic improvements #7653 @1a05698
bcc8ca1
@alexr4339
Copy link

Quality Assurance Tester Report

Discord : Alex R#6663
Object of testing: #PR 7653
Tier of Testing : 1
Date : 22/12/2022

Testing Process:
Updated A32NX to latest experimental.
Loaded the aircraft on the runway and took off. Armed ground spoilers and brought the bird to the landing config. Flew a cicuit and performed a normal approach and landing. Ground Spoilers extended normally and fully. Pushed levers to TOGA and went around. Spoilers retracted as expected. Brought it landing config again and flew the circuit. This time I did not flare and left the thrust levers around 45% N1. After (the hard) touchdown the spoilers extended halfway and RA showed 0. Due to the lift dumping as intended by Airbus in the PDF linked in this PR I did not even bounce so I pulled back and left the thrust where it was (45% N1) to simulate the bounce. I got in the air to about a RA of 2ft. Spoilers were still halfway extended and I really felt the lift dumping as intended by Airbus. Instead of touching down fully I ste TOGA thrust and went around, spoilers retracted fully as expected.

Negatives:
N/A

Testing Results:
Passed

@mico975
Copy link
Contributor

mico975 commented Dec 29, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: (#PR Number)
Tier of Testing : 1
Date : 29/12/2022

Testing Process:
Fixes an issue with the ground spoiler full extension, where the spoilers would extend when only one thrust lever was at idle, instead of both. - OK

Adds a condition to the partial extension, to reduce a possible bounce in the case of improper thrust handling on landing: The spoilers will partially extend when
The Ground Spoilers are armed
Both thrust levers are below the CLB notch
Both MLGs are compressed - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@lukecologne lukecologne enabled auto-merge (squash) December 29, 2022 20:40
@lukecologne lukecologne merged commit 0673106 into flybywiresim:master Dec 29, 2022
@lukecologne lukecologne deleted the gnd-splr-cond-fix branch December 29, 2022 20:42
Eearslya pushed a commit to Eearslya/a32nx that referenced this pull request Jan 4, 2023
@lukecologne @Eearslya
feat(sec): ground spoiler logic improvements (flybywiresim#7653)
fe3568f 
* fix(sec): fix bug where gnd splrs would extend with only one thr lvr at idle

* feat(sec): add partial gnd splr improper thr lvr condition

* chore: add changelog
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracernz tracernz tracernz approved these changes

Assignees
No one assigned
Labels
Exp Available on experimental branch (for testing)
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lukecologne @crocket63 @alexr4339 @mico975 @tracernz @2hwk @Saschl