You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The introduction of PR #8472 added a new type check for aircraft, focusing on verifying the titles of the aircraft against a list of pre-defined names. This measure was implemented to ensure consistency and accuracy in aircraft identification. However, a potential issue arises from the variability in how livery authors might title their aircraft liveries. Due to inconsistencies in naming conventions used by livery authors, there's a risk that this type check might not recognize some aircraft titles as expected. When the type check fails to identify an aircraft title correctly, it will result in the build_info.json information not being loaded. This could lead to complications, highlighting the need for a more flexible or comprehensive approach to aircraft verification.
Example of a bad livery aircraft.cfg
[VERSION]
major = 1
minor = 0
[VARIATION]
base_container = "..\FlyByWire_A320_NEO"
;===================== FLTSIM =====================
[FLTSIM.0]
title = "A32NX Lufthansa D-AIJC" ; Variation name
model = "" ; model folder
panel = "" ; panel folder
sound = "" ; sound folder
This is exactly the expected behavior, another approach is needed to be more consistent.
Steps to reproduce
Load the plane with a livery which has a "bad" title: e.g. title = "A32NX Lufthansa D-AIJC" ; Variation name
Open up EFB and switch to About page in Settings.
References (optional)
No response
Additional info (optional)
Another approach could be to add a new SimVar called "A32NX_AIRCRAFT_TYPE" and to check against the value of this SimVar. Still possible to change via the Debug Tools on runtime, but this could be only a edge case.
Discord Username (optional)
Revyn112
The text was updated successfully, but these errors were encountered:
Aircraft Version
Development
Build info
Describe the bug
The introduction of PR #8472 added a new type check for aircraft, focusing on verifying the titles of the aircraft against a list of pre-defined names. This measure was implemented to ensure consistency and accuracy in aircraft identification. However, a potential issue arises from the variability in how livery authors might title their aircraft liveries. Due to inconsistencies in naming conventions used by livery authors, there's a risk that this type check might not recognize some aircraft titles as expected. When the type check fails to identify an aircraft title correctly, it will result in the build_info.json information not being loaded. This could lead to complications, highlighting the need for a more flexible or comprehensive approach to aircraft verification.
Example of a bad livery aircraft.cfg
The fbw-common/src/systems/shared/src/aircraftTypeCheck.ts will search up the SimVar Title for A320 but only will find A32NX as case "other" and not loading up the build_info.json.
Expected behavior
This is exactly the expected behavior, another approach is needed to be more consistent.
Steps to reproduce
title = "A32NX Lufthansa D-AIJC" ; Variation name
References (optional)
No response
Additional info (optional)
Another approach could be to add a new SimVar called "A32NX_AIRCRAFT_TYPE" and to check against the value of this SimVar. Still possible to change via the Debug Tools on runtime, but this could be only a edge case.
Discord Username (optional)
Revyn112
The text was updated successfully, but these errors were encountered: