fix: fix ETA of TO waypoint display on ND #8252

alexmilshtein · 2023-10-14T13:46:03Z

fix: ETA of TO waypoint is not displayed prior to takeoff and after landing in real aircraft
doc: changelog

Summary of Changes

Fixes an issue where ETA of TO waypoint is visible on the ND prior to take-off and landing.
I decided to display it when the aircraft is detected to be off the ground and turn it off when it's on the ground (nose wheel pressure detected).

Screenshots (if necessary)

On the ground before the flight plan entered

On the ground after the flight plan entered

Take-off before rotation

Take-off after rotation

Approach

Roll-out with main gear on the ground

Roll-out with nose wheel on the ground

References

Take-off
https://www.youtube.com/watch?v=8DLYoj6S_lw&t=884s
Landing
https://youtu.be/rhI5XGwlnaI?t=269

Additional context

Discord username (if different from GitHub):
alexm1987

Testing instructions

Start Cold and Dark
Complete IRS alignment, observe PPOS is displayed on the ND but not ETA to TO and bearing. Before the change it was showing ETA 00:00 and bearing 000°.
Enter the flight plan, observe that there's still no ETA displayed on the ND, but bearing and distance are visible now.
Take-off as usual, as soon as GS (ground speed) goes above 100kts ETA becomes visible on the ND.
Upon landing when there's no more active legs in the flight plan left, ND switches to PPOS: ETA, bearing and distance are not visible. Another possibility if you manage to slow down to 100kts GS when the active leg is still active, ETA becomes unavailable.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

BravoMike99 · 2023-10-14T15:05:27Z

Hi, on Honeywell FMGS aircraft which the FBW is simulating, the ETA becomes available as soon as the FMS transitions to the takeoff phase (GS greater than 90kts assuming takeoff power is set) while on rollout it seems to disappear somewhere below 100kts. The behavior you implemented seems to be the one of the Thales FMS which is the case on the videos you provided. In case you want to change that, here are a few videos with Honeywell: https://youtu.be/8EHTmIsz1oI https://youtu.be/UQE-g7yrY3w https://youtu.be/A1D2X9KELkM

tracernz · 2023-10-15T00:52:35Z

Additionally, the value transmitted from the FMS should be changed rather than the ND code (it already transmits -1 when some other conditions that make the ETA not computed are present).

pinatacolada · 2023-10-15T15:08:08Z

PPOS and MANUAL shouldn't have any predictions too, so no bearing track or distance.

alexmilshtein · 2023-10-18T06:32:31Z

PPOS and MANUAL shouldn't have any predictions too, so no bearing track or distance.

@pinatacolada Can you, please, explain what MANUAL is in this context?

pinatacolada · 2023-10-18T08:46:57Z

It's when the current leg is a MANUAL leg, the to waypoint is displayed as MANUAL without any prediction

tracernz · 2023-10-18T10:09:36Z

FM/VM legs.

alexmilshtein · 2023-10-18T11:32:24Z

Hey all, I've refactored a bit:

ETA, distance, bearing is not shown when there no active leg, e.g. PPOS
Once flight plan is there on the ground, bearing and distance is visible
On take-off, once the ground speed reached 95kt, eta becomes visible
On landing, without Go-Around (missed approach) support, one cannot actually see ETA going away once the speed is below certain threshold, the reason being that once you land there are no more active legs, and ND switches to PPOS, so distance, bearing and eta are gone right away.

* fix: ETA of TO waypoint is not displayed prior to takeoff and after landing in real aircraft * doc: changelog

* Move the logic to guidance controller, outside of ND and LnavDriver This allows to update Efis after the are no more active legs

alepouna · 2023-10-30T12:32:20Z

QA Report

Discord: alepouna
Object of testing: #8252
Tier of Testing : 1
Date : 30/10/2023

Testing Process:

Start Cold and Dark
[PASS] Complete IRS alignment, observe PPOS is displayed on the ND but not ETA to TO. Before the change it was showing 00:00.
[PASS] Enter the flight plan, observer that there's still no ETA displayed on the ND.
[PASS] Take-off as usual, as soon as rotation happens and nose wheel lifts off the ground ETA is displayed.
[PASS] Land and observe that as soon as the nose wheel touches the runway ETA is gone.

Testing Results:
Passed

BlueberryKing · 2023-10-30T22:17:07Z

fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts

@@ -112,6 +115,8 @@ export class GuidanceController {

    verticalProfileComputationParametersObserver: VerticalProfileComputationParametersObserver;

+    lastActiveLeg: Leg | null;


What is this used for?

This is used to update efis with the data based on the active leg computed by the LnavDriver.
If there's no more active leg, ETA, bearing and distance will be updated not to appear on the ND.

Ah, my apologies, I missed that somehow 😄. Nevertheless, I think the property is redundant because we already store activeGeometry and activeLegIdx in the GuidanceController, so we can just derive the active leg there, rather than having it set in LnavDriver. This is just a minor thing though, so let me know if you have a different opinion.

no worries, probably you're right on this one.
I've made the change, have a look.

fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts

Co-authored-by: BBK <[email protected]>

BlueberryKing

Nice work!

alepouna · 2023-11-02T16:45:08Z

QA Report

Discord: alepouna
Object of testing: #8252
Tier of Testing : 1
Date : 02/11/2023

Testing Process:

Start Cold and Dark
[PASS] Complete IRS alignment, observe PPOS is displayed on the ND but not ETA to TO. Before the change it was showing 00:00.
[FAIL] Enter the flight plan, observer that there's still no ETA displayed on the ND.

Negatives:
See above

Testing Results:
Not Passed

Edit:
Fixed instructions and negative comment as I skipped one step on the report writeup.

alexmilshtein · 2023-11-03T08:13:28Z

QA Report

Discord: alepouna Object of testing: #8252 Tier of Testing : 1 Date : 02/11/2023

Testing Process:

Start Cold and Dark

[FAIL] Complete IRS alignment, observe PPOS is displayed on the ND but not ETA to TO. Before the change it was showing 00:00.

Negatives: See above

Testing Results: Not Passed

There's some confusion here :)
Not showing any ETA and bearing when it's PPOS is intentional. This is implemented to take on-board the feedback #8252 (comment)
ETA to TO is visible only when:

Flight plan is active
GS > 100 kts during take-off and later phases, not pre take-off
Bearing and distance are visible only when there's an active leg in the flight plan.

Update:
Re-read this again.
Maybe I'm interpreting this wrong, let me have a quick look first.

alexmilshtein · 2023-11-03T09:34:59Z

I tested this out for the preflight phase:
Before alignment no bearing, distance and prediction on ND.

After alignment before flight plan is entered

After flight plan is entered bearing and distance are visible, but not ETA

Please, try building with --no-cache

BravoMike99 · 2023-11-03T14:34:08Z

It might also be a good idea to update the summary of changes & testing instructions to the honeywell behavior (GS based) as they still refer the Thales behavior/before the changes.

alexmilshtein · 2023-11-04T03:08:54Z

It might also be a good idea to update the summary of changes & testing instructions to the honeywell behavior (GS based) as they still refer the Thales behavior/before the changes.

You're right, I should've updated instructions.
The steps are now updated to reflect Honeywell specific behaviour.

alepouna · 2023-11-06T21:03:05Z

Please, try building with --no-cache

I have downloaded the artifact provided by the GitHub action as it is the same (to my knowledge) artifact that is provided to the end users. I have re-downloaded the artifact and still can reproduce the issue.

PS: My mistake earlier for the confusion on the issue, I "ate" a step on the testing instruction report. Have updated my comment.

alexmilshtein · 2023-11-06T23:43:04Z

Please, try building with --no-cache

I have downloaded the artifact provided by the GitHub action as it is the same (to my knowledge) artifact that is provided to the end users. I have re-downloaded the artifact and still can reproduce the issue.

PS: My mistake earlier for the confusion on the issue, I "ate" a step on the testing instruction report. Have updated my comment.

Can you, please, provide the flight plan you’re using? I’ll try to replicate it. I’m not sure why it’s not working for you.

alexmilshtein · 2023-11-09T14:06:44Z

I honestly don't know what's going on here.
I've downloaded the artifact myself and checked, it's not showing ETA when on the ground.

Mack674 · 2024-02-11T13:37:05Z

Quality Assurance Tester Report

Discord: Mack674#2274
Object of testing: #8252
Tier of Testing: 1
Date: 11/02/2024

Testing Process:
(Full flight EGLL - EGCC)

Powered up from C&D at LHR
Did a routine flight according to procedures
Observed ND indications behaviour
Logged off at gate at MAN

Negatives: N/A

Testing Results: Passed

Conclusions: Works as intended, great job!

Media:

alexmilshtein force-pushed the fix-eta-to-preflight branch from d723791 to 38d3535 Compare October 18, 2023 11:26

alexmilshtein force-pushed the fix-eta-to-preflight branch from 5cc4ac2 to df31e26 Compare October 20, 2023 08:14

alexmilshtein added 4 commits October 23, 2023 22:23

fix: fix ETA of TO waypoint display on ND

fa8dc7d

* fix: ETA of TO waypoint is not displayed prior to takeoff and after landing in real aircraft * doc: changelog

Refactor ETA and bearing calculation

41da562

* Move the logic to guidance controller, outside of ND and LnavDriver This allows to update Efis after the are no more active legs

Remove nose compressed logic from ND

6d8d368

Update gs to 100kts

438e597

alexmilshtein force-pushed the fix-eta-to-preflight branch from c81bf85 to 438e597 Compare October 23, 2023 11:23

tracernz added the QA Tier 1 label Oct 24, 2023

tracernz added this to the v0.12.0 milestone Oct 24, 2023

tracernz added 2 commits October 24, 2023 20:56

Merge branch 'master' into fix-eta-to-preflight

d61aac4

fix: changelog 0.12

80a7094

github-actions bot added the QA Passed label Oct 30, 2023

BlueberryKing reviewed Oct 30, 2023

View reviewed changes

Derive active leg from geomerty wihin efis update

ab79c0e

BlueberryKing reviewed Nov 2, 2023

View reviewed changes

fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts Outdated Show resolved Hide resolved

Add null check

b6a9c09

Co-authored-by: BBK <[email protected]>

BlueberryKing approved these changes Nov 2, 2023

View reviewed changes

Merge branch 'master' into fix-eta-to-preflight

acab26d

github-actions bot added the QA Failed label Nov 2, 2023

github-actions bot removed the QA Passed label Nov 2, 2023

Merge branch 'master' into fix-eta-to-preflight

af784ba

tracernz enabled auto-merge (squash) February 14, 2024 04:59

Merge branch 'master' into fix-eta-to-preflight

35d055e

tracernz merged commit 5b563ff into flybywiresim:master Feb 14, 2024
7 checks passed

2hwk modified the milestones: v0.12.0, v0.11.2 Feb 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix ETA of TO waypoint display on ND #8252

fix: fix ETA of TO waypoint display on ND #8252

alexmilshtein commented Oct 14, 2023 •

edited

Loading

BravoMike99 commented Oct 14, 2023 •

edited

Loading

tracernz commented Oct 15, 2023

pinatacolada commented Oct 15, 2023

alexmilshtein commented Oct 18, 2023

pinatacolada commented Oct 18, 2023

tracernz commented Oct 18, 2023

alexmilshtein commented Oct 18, 2023 •

edited

Loading

alepouna commented Oct 30, 2023

BlueberryKing Oct 30, 2023

alexmilshtein Nov 1, 2023

BlueberryKing Nov 1, 2023

alexmilshtein Nov 2, 2023

BlueberryKing left a comment

alepouna commented Nov 2, 2023 •

edited

Loading

alexmilshtein commented Nov 3, 2023 •

edited

Loading

alexmilshtein commented Nov 3, 2023

BravoMike99 commented Nov 3, 2023 •

edited

Loading

alexmilshtein commented Nov 4, 2023

alepouna commented Nov 6, 2023

alexmilshtein commented Nov 6, 2023

alexmilshtein commented Nov 9, 2023

Mack674 commented Feb 11, 2024

		@@ -112,6 +115,8 @@ export class GuidanceController {

		verticalProfileComputationParametersObserver: VerticalProfileComputationParametersObserver;

		lastActiveLeg: Leg \| null;

fix: fix ETA of TO waypoint display on ND #8252

fix: fix ETA of TO waypoint display on ND #8252

Conversation

alexmilshtein commented Oct 14, 2023 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

BravoMike99 commented Oct 14, 2023 • edited Loading

tracernz commented Oct 15, 2023

pinatacolada commented Oct 15, 2023

alexmilshtein commented Oct 18, 2023

pinatacolada commented Oct 18, 2023

tracernz commented Oct 18, 2023

alexmilshtein commented Oct 18, 2023 • edited Loading

alepouna commented Oct 30, 2023

BlueberryKing Oct 30, 2023

Choose a reason for hiding this comment

alexmilshtein Nov 1, 2023

Choose a reason for hiding this comment

BlueberryKing Nov 1, 2023

Choose a reason for hiding this comment

alexmilshtein Nov 2, 2023

Choose a reason for hiding this comment

BlueberryKing left a comment

Choose a reason for hiding this comment

alepouna commented Nov 2, 2023 • edited Loading

alexmilshtein commented Nov 3, 2023 • edited Loading

alexmilshtein commented Nov 3, 2023

BravoMike99 commented Nov 3, 2023 • edited Loading

alexmilshtein commented Nov 4, 2023

alepouna commented Nov 6, 2023

alexmilshtein commented Nov 6, 2023

alexmilshtein commented Nov 9, 2023

Mack674 commented Feb 11, 2024

alexmilshtein commented Oct 14, 2023 •

edited

Loading

BravoMike99 commented Oct 14, 2023 •

edited

Loading

alexmilshtein commented Oct 18, 2023 •

edited

Loading

alepouna commented Nov 2, 2023 •

edited

Loading

alexmilshtein commented Nov 3, 2023 •

edited

Loading

BravoMike99 commented Nov 3, 2023 •

edited

Loading