Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust version + disable unsupported optimizations #8242

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Oct 5, 2023

Fixes #[issue_no]

Summary of Changes

Requires https://github.com/flybywiresim/dev-env/pull/11 and flybywiresim/msfs-rs#17 to be merged first. Docker image also needs to be updated after dev-env change has been merged. Done.

Use recent rust version and disable sign extension that is enabled by default and added by wasm-opt, but is unsupported by the msfs runtime. Also fixes some clippy errors that came up with newer versions

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

No changes are expected. The plane should behave as usual.

Especially watch that the electrical and hydraulic system are working as usual.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Saschl Saschl force-pushed the prepare-for-update branch from 281c193 to ea07d26 Compare October 5, 2023 11:45
@Gurgel100
Copy link
Contributor

You'll need to update the msfs crate once flybywiresim/msfs-rs#17 is merged.

@tracernz tracernz added this to the v0.12.0 milestone Oct 24, 2023
@Saschl Saschl marked this pull request as ready for review October 27, 2023 06:47
@alepouna
Copy link
Member

alepouna commented Nov 2, 2023

QA Report

Discord: alepouna
Object of testing: #8242
Tier of Testing : 1
Date : 02/11/2023

Testing Process:

  • Test various systems, perform a flight.

Negatives:

  • Terrain ND overlay shows up in some ND views but its completely borked as shown below:
    image
    image
    image

Notes:
Simbridge was connected before flight started (simbridge running w/ autoconnect on) - no artifacts as the above in latest dev branch.

Testing Results:
Not Passed

@Saschl Saschl added QA Failed and removed QA Failed labels Nov 2, 2023
@alepouna
Copy link
Member

alepouna commented Nov 2, 2023

QA Report

Discord: alepouna
Object of testing: #8242
Tier of Testing : 1
Date : 02/11/2023

Testing Process:

  • Test various systems, perform a flight.

Testing Results:
Passed

@Saschl Saschl merged commit a74a618 into flybywiresim:master Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants