Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More resilient file saving by a two-stage file save process #1128

Open
flxzt opened this issue Jun 26, 2024 · 1 comment · May be fixed by #1177
Open

More resilient file saving by a two-stage file save process #1128

flxzt opened this issue Jun 26, 2024 · 1 comment · May be fixed by #1177
Labels
enhancement New feature or request

Comments

@flxzt
Copy link
Owner

flxzt commented Jun 26, 2024

As mentioned in #1096 it would be very nice to improve the save logic by first saving to a temporary second file and overwriting the first when writing the file actually succeeded.

Right now we are directly overwriting the file, which can corrupt files when the app exits unexpectedly while saving.

@flxzt flxzt added the enhancement New feature or request label Jun 26, 2024
@RayJW
Copy link
Contributor

RayJW commented Jun 27, 2024

While the discussion is already at it, how exactly are the files overwritten? From a security standpoint, overwriting can be a risk by making deleted data recoverable (see aCropalypse). Not sure how relevant that is, but I don't know the use case for Rnote of all people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants