Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency): fix incorrect dependency resolution by favouring latest #143

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

azlam-abdulsalam
Copy link

Fixes Incorrect dependency resolution post v39.2.1 #142

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

when duplicates are found

Fixes Incorrect dependency resolution post v39.2.1 #142
@azlam-abdulsalam azlam-abdulsalam added this to the December 24 milestone Dec 1, 2024
@azlam-abdulsalam azlam-abdulsalam self-assigned this Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 96.84211% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.41%. Comparing base (2bd58ec) to head (da221ba).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
...ckage/dependencies/TransitiveDependencyResolver.ts 96.84% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   46.36%   46.41%   +0.04%     
==========================================
  Files          73       72       -1     
  Lines        2836     3447     +611     
  Branches      328      760     +432     
==========================================
+ Hits         1315     1600     +285     
- Misses       1496     1704     +208     
- Partials       25      143     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rocko1204 Rocko1204 self-requested a review December 3, 2024 07:54
Copy link
Collaborator

@Rocko1204 Rocko1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything ok!

@azlam-abdulsalam azlam-abdulsalam merged commit 5e0dd5b into main Dec 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants