feat(pool): add password to fetched scratch org from pool #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAertgeerts
approved these changes
Nov 6, 2024
|
@thvd thank you for your contribution! |
dieffrei
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came as a proposal after getting stuck with this: (posted on the Slack channel)
Is there a reason why sfp doesn't persist the password in sf cli auth config after fetching a scratch org from the pool?
The reason I why I ask this is because Provar does generate a new password when it runs thus overriding the password as filled in the prod org
Password__cfield.Reference to Provar source code: https://github.com/ProvarTesting/provardx/blob/development/src/utilities/ProvarDXUtility.ts#L112
I am thinking of figuring this out myself and providing a PR to sfp, what are your thoughts on this change?