fix: remove encode/decore uri on picklist values #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo Code Review 📊 ✅ All checks passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 46.36% 45.49% -0.87%
==========================================
Files 73 71 -2
Lines 2836 3299 +463
Branches 328 714 +386
==========================================
+ Hits 1315 1501 +186
- Misses 1496 1661 +165
- Partials 25 137 +112 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some tests and notice that values coming from tooling api API they already come decoded, no needed for decode/encondingURI.
I assume that source-retrieve lib already handles this encoding.
As described in the image above, the value is already decoded, when trying to decode, you get the error "URI malformed"
I create a draft PR, to have some earlier feedback.
It still requires more testing
Checklist
All items have to be completed before a PR is merged