You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
I know we are almost against dependencies but I believe this one worth the discussion (maybe immutable.js?).
As we spoke and tried to do a couple times, the data property would be better as a immutable structure, so, assigning a new attribute would make a entire new copy, like this:
That would allow us to avoid things like lastGeneratedJSON machinery as we can just pass the data property as the result of toJSON, #46 machinery as we can just keep a copy of the data property and compare latter as the above example and even the machinery to keep nested objects with their own object ids.
But the winner here would be components with a just oldProps !== newProps compare to re-render the entire component tree.
Do you think worth the research to make something like that?
I'm not against we building our own embed immutable library to avoid the immutable.js but that path may be tough, we can just assume that data would be immutable and work on that.
The text was updated successfully, but these errors were encountered:
I know we are almost against dependencies but I believe this one worth the discussion (maybe immutable.js?).
As we spoke and tried to do a couple times, the data property would be better as a immutable structure, so, assigning a new attribute would make a entire new copy, like this:
That would allow us to avoid things like
lastGeneratedJSON
machinery as we can just pass the data property as the result oftoJSON
, #46 machinery as we can just keep a copy of the data property and compare latter as the above example and even the machinery to keep nested objects with their own object ids.But the winner here would be components with a just
oldProps !== newProps
compare to re-render the entire component tree.Do you think worth the research to make something like that?
I'm not against we building our own embed immutable library to avoid the immutable.js but that path may be tough, we can just assume that data would be immutable and work on that.
The text was updated successfully, but these errors were encountered: