Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Libgit2 Managed Transport by Default #689

Closed
pjbgf opened this issue Apr 26, 2022 · 0 comments · Fixed by #718
Closed

Enable Libgit2 Managed Transport by Default #689

pjbgf opened this issue Apr 26, 2022 · 0 comments · Fixed by #718
Labels
area/git Git related issues and pull requests
Milestone
Helm GA

Comments

@pjbgf
Copy link
Member

pjbgf commented Apr 26, 2022

Managed Transport was introduced in source-controller v0.22 and ever since has been kept behind a feature gate.

This feature already behaves in more predictable ways than the unmanaged libgit2 alternative.
Therefore, this feature should be enabled by default once all known issues are mitigated (#636) or there are good enough work-arounds for unmitigated issues.
@pjbgf pjbgf added the area/git Git related issues and pull requests label Apr 26, 2022
@pjbgf pjbgf added this to the GA milestone Apr 26, 2022
@pjbgf pjbgf moved this to Up-Next in Maintainers' Focus Apr 26, 2022
@pjbgf pjbgf moved this from Up-Next to In Progress in Maintainers' Focus May 19, 2022
@pjbgf pjbgf mentioned this issue May 19, 2022
Merged
Repository owner moved this from In Progress to Done in Maintainers' Focus May 24, 2022
@pjbgf pjbgf mentioned this issue May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/git Git related issues and pull requests
Projects
Maintainers' Focus
Status: Done
Milestone
Helm GA
Development

Successfully merging a pull request may close this issue.

libgit2: enable managed transport by default pjbgf/source-controller
1 participant
@pjbgf