Resolve index out of range when running locally

[pjbgf]

The controller may panic depending on the HOSTNAME defined. This is not a problem when running as a pod with the default source-controller name, however, it fails when users try to run the controller on their local machines if RUNTIME_NAMESPACE is non empty and their machine names does not contain hyphens.

	if os.Getenv("RUNTIME_NAMESPACE") != "" {
		svcParts := strings.Split(os.Getenv("HOSTNAME"), "-")
		return fmt.Sprintf("%s.%s",
			strings.Join(svcParts[:len(svcParts)-2], "-"), os.Getenv("RUNTIME_NAMESPACE"))
	}

https://github.com/fluxcd/source-controller/blob/main/main.go#L317-L321

[EdwinWalela]

How about checking the length of svcParts where if it's equal to 1 (meaning there is no hyphen) we return just the environment variable as it is?

[pjbgf]

@EdwinWalela we should be able to remove that if block (and the two comments above it) completely and just rely on the storageAddr that is passed in. Are you keen on proposing a PR for this?

[EdwinWalela]

@pjbgf That's even better. Sure, I can take this up

[pjbgf]

That's awesome, @EdwinWalela. I have assigned the issue to you.

[pjbgf]

Fixed by #672