You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the reconcilers-dev branch we have started to be more informative about the precise actions that were taken during a reconcile run.
At present, this means that it will tell that it (successfully) run the garbage collection. It would however be more meaningful if we only pushed an event if any items were collected, or a failure occurred.
To be able to determine this, we need to know the number of items that were removed. We could do better however, and at least collect details about the precise items that were removed.
Relevant lines in reconcilers are at present marked with:
// TODO(hidde): we should only push this event if we actually garbage collected something
The text was updated successfully, but these errors were encountered:
hi @hiddeco I checked out reconcilers-dev to my local but the makefile doesn't seem to work on my Intel MacOs. Do you think it's possible to do a pull rebase from main or cherry-pick #515 to this branch?
well I tried to cherry-pick that to reconcilers-dev on my local and encountered merge conflicts. But a copy-paste of Makefile from main just did the trick to at least allow me to run makefile.
In the
reconcilers-dev
branch we have started to be more informative about the precise actions that were taken during a reconcile run.At present, this means that it will tell that it (successfully) run the garbage collection. It would however be more meaningful if we only pushed an event if any items were collected, or a failure occurred.
To be able to determine this, we need to know the number of items that were removed. We could do better however, and at least collect details about the precise items that were removed.
Relevant lines in reconcilers are at present marked with:
// TODO(hidde): we should only push this event if we actually garbage collected something
The text was updated successfully, but these errors were encountered: