Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last commit message in source-controller event notification #381

Closed
HaveFun83 opened this issue Jun 10, 2021 · 5 comments · Fixed by #586
Closed

Last commit message in source-controller event notification #381

HaveFun83 opened this issue Jun 10, 2021 · 5 comments · Fixed by #586
Labels
area/git Git related issues and pull requests enhancement New feature or request

Comments

@HaveFun83
Copy link

Hi
it will be great to see also the commit message from the fetched git revision in source-controller event notifications within a feature release.

thanks for this awesome project.

regards

@hiddeco
Copy link
Member

hiddeco commented Jun 10, 2021

Can you provide an example (or multiple) where you would benefit from this information, just so that others can understand your desire too?

@HaveFun83
Copy link
Author

Can you provide an example (or multiple) where you would benefit from this information, just so that others can understand your desire too?

sure.
currently the notifiaction towards mattermost looks like

gitrepository/common.flux-system
Fetched revision: master/9c1a795d38d4c9b4f0f0307e7330465d0f3a24ed

It will be great to see the commit message that another person have more human readable context to derive something here.
example:

gitrepository/common.flux-system
Fetched revision: master/9c1a795d38d4c9b4f0f0307e7330465d0f3a24ed
Message: podinfo update to v5.0.0

maybe is can be an optional option within the notification crd?

@hiddeco
Copy link
Member

hiddeco commented Jun 10, 2021

I think fluxcd/notification-controller#209 and fluxcd/notification-controller#195 are of interest to you.

@stefanprodan
Copy link
Member

@hiddeco those issues can't help here, source-controller has to look for the commit message and append it to the event metadata. After this is implemented here, then notification templates would be step 2.

@stefanprodan stefanprodan added area/git Git related issues and pull requests enhancement New feature or request labels Jun 10, 2021
@hiddeco
Copy link
Member

hiddeco commented Jun 10, 2021

I think the notification templates would be step one as this would answer the standardization of metadata labels, this would prevent a wild growth of labels that essentially have the same meaning within the context of the origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants