-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last commit message in source-controller event notification #381
Comments
Can you provide an example (or multiple) where you would benefit from this information, just so that others can understand your desire too? |
sure.
It will be great to see the commit message that another person have more human readable context to derive something here.
maybe is can be an optional option within the notification crd? |
I think fluxcd/notification-controller#209 and fluxcd/notification-controller#195 are of interest to you. |
@hiddeco those issues can't help here, source-controller has to look for the commit message and append it to the event metadata. After this is implemented here, then notification templates would be step 2. |
I think the notification templates would be step one as this would answer the standardization of metadata labels, this would prevent a wild growth of labels that essentially have the same meaning within the context of the origin. |
Hi
it will be great to see also the commit message from the fetched git revision in source-controller event notifications within a feature release.
thanks for this awesome project.
regards
The text was updated successfully, but these errors were encountered: