-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications of errors and recoveries #76
Comments
This would require notification-controller to be aware of previous events unless the Kustomization or Helm controller can do this. Either way I do not think it is a good idea for the notification controller to track state of different events. I do however think it would be feasible to implement this in the one of the other controllers so that they send events when a resource recovers. |
This needs to be fixed somewhere, either having the notification controller stateful or all other controllers only sending events in some circumstances. Also see fluxcd/kustomize-controller#203 where I reported this issue as well. |
I will close this issue as the notification controller has implemented a rate limiter to the event handler. |
It would be nice if we could have a setting which would allow to be notified when:
This would limit notification traffic to what's really important.
Regards.
The text was updated successfully, but these errors were encountered: