From d7cfa5d496b8f1ec939f455c49de5b21737cb8e9 Mon Sep 17 00:00:00 2001 From: Stefan Prodan Date: Fri, 1 Apr 2022 15:29:50 +0300 Subject: [PATCH] Add dedicated reconcilers to the design docs Signed-off-by: Stefan Prodan --- rfcs/helm-oci/README.md | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/rfcs/helm-oci/README.md b/rfcs/helm-oci/README.md index b03fba6cf9..59533e81ce 100644 --- a/rfcs/helm-oci/README.md +++ b/rfcs/helm-oci/README.md @@ -153,13 +153,18 @@ Bucket API design, where the same Kind servers different implementations: AWS S3 ## Design Details -In source-controller we'll add a new predicate for indexing `HelmRepositories` based on the `spec.type` field. +In source-controller we'll add a new predicate for filtering `HelmRepositories` based on the `spec.type` field. -When the `spec.type` field is set to `OCI`, the `HelmRepositoryReconciler` -will set the `HelmRepository` Ready status to `False` if the URL is not prefixed with `oci://`, -otherwise the Ready status will be set to `True`. +The current `HelmRepositoryReconciler` will be renamed to `HelmRepositoryDefaultReconciler`, +it's scope remains unchanged, and it will handle only objects with `type: Default`. + +We'll introduce a new reconciler named `HelmRepositoryOCIReconciler`, that will handle +objects with `type: OCI`. This reconciler will set the `HelmRepository` Ready status to +`False` if the URL is not prefixed with `oci://`, otherwise the Ready status will be set to `True`. + +The current `HelmChartReconciler` will be renamed to `HelmChartDefaultReconciler`, +it's scope remains unchanged, and it will handle only objects that refer to `HelmRepositories` with `type: Default`. -The current `HelmChartReconciler` will use the `HelmRepositories` with `type: Default`. For `type: OCI` we'll introduce a new reconciler `HelmChartOCIReconciler` that uses `oras` to download charts and their dependencies.