github push hook causes kubectl to be run constantly

[rade]

Extracted from #926...

In the weaveworks sock shop cluster I observed fluxd running kubectl every few seconds. See #926 (comment)

@squaremo discovered that there was a github hook configured, and removing that stopped this behaviour.

What's puzzling here is that the underlying repo receives just ~1 commit a day, so the hook should not be triggered frequently.

One theory here is that flux is doing some git tagging when sync'ing, and that in turn is triggering the hook, which in turn would trigger more sync'ing.

[squaremo]

One theory here is that flux is doing some git tagging when sync'ing, and that in turn is triggering the hook, which in turn would trigger more sync'ing.

Maybe, but the daemon doesn't attempt to push a new tag unless the head commit has changed, and I'd expect it to log that it was doing so. Maybe there's some corner case for this particular repo; one could try installing the hook for a fresh flux-example to see if it happens there too.

[squaremo]

Also: this really belongs as a bug against the service, not here.