Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Implement image manifest request with HTTP rather than client #790

Closed
squaremo opened this issue Oct 17, 2017 · 2 comments
Closed

Implement image manifest request with HTTP rather than client #790

squaremo opened this issue Oct 17, 2017 · 2 comments

Comments

@squaremo
Copy link
Member

Follow on from #780: it is not ideal to try to fetch one schema of manifest, check for a particular error and fail, then fetch the other. And more of a problem, this still doesn't account for signed manifests.

Since the manifest schema version is decided by content negotiation (hooray for sane use of HTTP!), it'd be much better to just issue an HTTP request with an Accept header, and deal with whatever Content-Type we get back. This would also go towards helping #741 (we'd at least be able to discard images that aren't for linux/amd64, rather than failing to update the repo).

@squaremo
Copy link
Member Author

squaremo commented Oct 17, 2017

This may precipitate a rewrite of the registry code to not use docker-registry-client -- the only really tricky bit of what the client does is authentication, otherwise we are mostly working around its limitations, with #780 and the various RoundTripper implementations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants