Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Release events can detail incorrect serviceIDs #729

Closed
awh opened this issue Sep 5, 2017 · 0 comments
Closed

Release events can detail incorrect serviceIDs #729

awh opened this issue Sep 5, 2017 · 0 comments

Comments

@awh
Copy link
Contributor

awh commented Sep 5, 2017

When the daemon syncs it has the following behaviour:

  1. Clone repo and invoke kubectl apply for all resources
  2. Determine all services that have changed since the last sync
  3. Send a history.EventSync
  4. Send a history.EventRelease or history.EventAutoRelease event for every release commit since the last sync

Because the release commit notes do not contain a list of affected service IDs for that specific commit (it just hast the release spec) the daemon includes the list of services affected by the entire sync operation in each event sent in step 4. If the sync contains only one release commit, this is correct; if it contains more than one release commit, it will incorrectly detail that each commit affected the total set of services.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants