Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Store whole image data in one place #710

Closed
squaremo opened this issue Aug 22, 2017 · 3 comments
Closed

Store whole image data in one place #710

squaremo opened this issue Aug 22, 2017 · 3 comments

Comments

@squaremo
Copy link
Member

At the minute, each scan of our local image manifests involves a large number of memcache requests (one for tags, then one for each tag). It'd be nice to be able to just fetch one thing; when we've managed to assemble a whole set of data, we can regenerate it.

@philwinder
Copy link
Contributor

The reason for doing it this way was so that it matches the flow of getting information from a remote repository.

E.g. we have to make an individual HTTP call to get the manifest for each tag.

I think it would complicate the code if we had a different scheme for memcache. So I would only consider this if there was a clear benefit for doing so (i.e. performance).

@squaremo
Copy link
Member Author

So I would only consider this if there was a clear benefit for doing so (i.e. performance).

The idea is that you do one request to memcached instead of hundreds, of which any single request failing will invalidate the whole operation.

@squaremo
Copy link
Member Author

(But it is just an idea. I agree that unless it's demonstrably a problem in practice, which I only suspect at this time, we shouldn't hurry to look into this)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants