Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Consider porting from kubeyaml to py-yamler or similar #1120

Closed
squaremo opened this issue Jun 5, 2018 · 1 comment
Closed

Consider porting from kubeyaml to py-yamler or similar #1120

squaremo opened this issue Jun 5, 2018 · 1 comment

Comments

@squaremo
Copy link
Member

squaremo commented Jun 5, 2018

As of #976, we run YAML updates through kubeyaml, which is a vast improvement. But it's not very flexible -- kubeyaml has to understand each format we want to be able to update (e.g., FluxHelmReleases), and each kind of update we want to do.

At the minute, we do some analysis of manifests in Go code, and some in kubeyaml, and these have to line up. For example, both have to agree on how FluxHelmReleases encode the image in use in the chart.

If we used a library that supported arbitrary changes to YAMLs, then we'd be able to do the analysis of what to change only in fluxd (and have to change only fluxd to support new formats or kinds of update).

@kingdonb
Copy link
Member

In Flux v2, Kustomize's kyaml setters feature is used instead of manipulating YAML directly inside of Flux components.

Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants