Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Helm releasesync does git pull after having computed changes, but before applying them #1092

Closed
ncabatoff opened this issue May 21, 2018 · 1 comment

Comments

@ncabatoff
Copy link
Contributor

I noticed while working on #1089 that the 'git pull' is done after having examined the repo and compared it to the cluster to determine what changes to make. So we figure out what to do, then git pull, then apply changes based on a potentially stale plan. Looks like a bug to me. See releasesync.ReleaseChangeSync.sync() for the pull in question.

@squaremo
Copy link
Member

This is no longer the case after #1240 (use the same git code as fluxd); the git mirroring is done only in *Repo.Start(...), and not ad-hoc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants