Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HPA Behaviour (autosacaling/v2beta2) #727

Closed
tr-fteixeira opened this issue Nov 16, 2020 · 2 comments
Closed

Support for HPA Behaviour (autosacaling/v2beta2) #727

tr-fteixeira opened this issue Nov 16, 2020 · 2 comments
Labels
kind/feature Feature request

Comments

@tr-fteixeira
Copy link
Contributor

Initially thought it was a bug, but now seems more like a feature/enhancement.

While testing new HPA functionality introduced in k8s 1.18 on autoscaling/v2beta2, we've noticed that the -primary copies of the resources didn't have the proper spec definition.

Digging a bit further, seems like it is just not there yet..

The proposal is: this would need to be changed to v2 and

Behavior:    hpa.Spec.Behavior,

added here and on a few other places, 2 or 3 at most.

And as we are adding something new, would also need to validate the contents before updates, here.

Let me know if that works or if there are any concerns with the approach..
Thanks =)

@stefanprodan
Copy link
Member

stefanprodan commented Nov 17, 2020

My only concern is about Kubernetes version compatibility, Flagger supports Kubernetes >= 1.14. Does autoscaling/v2beta2 work on 1.14, is the Behavior field ignored?

@stefanprodan
Copy link
Member

Implemented in #740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants