-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SMI apiVersion configurable for SMI based service mesh providers #551
Comments
Do you know of any SMI implementation using v1alpha2 or v1alpha3? |
Support for SMI v1alpha3 is needed for NGINX Service Mesh that uses v1alpha3 and it may work with flagger if this gets sorted out. |
If that were true I would’ve done it ages ago :)) Maybe you are not aware but v1alpha3 is not backwards compatible and it will break Linkerd. Both v1alpha2 and v1alpha3 come with breaking changes, so Flagger needs to support them all in parallel. |
thats the problem... NSM have implemented v1a3 and it crashes on flagger.
@stefanprodan appreciate that you bringing this back to life :) |
Currently Flagger is supporting
v1alpha1
of SMI traffic split policy. Different SMI based mesh providers might use different versions of SMI, making it not feasible to use Flagger in its current form by pinning to one specific SMI version.Looking at #376, it seems like Flagger can support
v1alpha2
of SMI but it just isn't the default because of dependency on Linkerd to update to SMIv1alpha2
.Since its natural for different implementations of SMI mesh providers to use different SMI versions, is it possible to make the SMI version configurable as long as Flagger has the code to work with that version? This will obviate the need to depend on mesh provider's SMI versioning.
The text was updated successfully, but these errors were encountered: