Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support latest v1alpha3 Istio DestinationRule attributes #439

Closed
brucedlg opened this issue Feb 13, 2020 · 0 comments · Fixed by #441
Closed

support latest v1alpha3 Istio DestinationRule attributes #439

brucedlg opened this issue Feb 13, 2020 · 0 comments · Fixed by #441
Labels
kind/bug Something isn't working

Comments

@brucedlg
Copy link

brucedlg commented Feb 13, 2020 •
edited
Loading

Flagger 0.23.0 / Istio 1.4.3

Currently there is gap between v1alpha3 Istio DestinationRule used by Flagger and the latest v1alpha3 Istio DestinationRule defined by Istio.

The link to Flagger definition:
https://github.com/weaveworks/flagger/blob/0.23.0/pkg/apis/istio/v1alpha3/destination_rule.go

The link to Istio definition:
https://github.com/istio/api/blob/master/networking/v1alpha3/destination_rule.proto

Here list some missing attributes, which may not be exhaustive:

  • outlierDetection.minHealthPercent
  • connectionPool.http.idleTimeout
  • connectionPool.http.h2UpgradePolicy

Is it possible to support these attributes?
@stefanprodan stefanprodan mentioned this issue Feb 14, 2020
Merged
@stefanprodan stefanprodan added the kind/bug Something isn't working label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend Istio traffic policy fluxcd/flagger
2 participants
@stefanprodan @brucedlg