Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary stuck after failed deployment #379

Closed
giggio opened this issue Nov 25, 2019 · 4 comments · Fixed by #380
Closed

Canary stuck after failed deployment #379

giggio opened this issue Nov 25, 2019 · 4 comments · Fixed by #380
Labels
kind/bug Something isn't working

Comments

@giggio
Copy link

giggio commented Nov 25, 2019

We are trying to upgrade a release from a Helm chart, and skip analysis is being used. It seems that some problem brought flagger to a state that locked any progress.

Logs show, in order, several of each:

Synced ns/release

Halt advancement release-primary.ns deployment \"release-primary\" exceeded its progress deadline

Halt advancement release-primary.ns waiting for rollout to finish: 1 old replicas are pending termination

After that, there is one log every 20 seconds with the same message:

Halt advancement release-primary.ns deployment \"release-primary\" exceeded its progress deadline

If you try to create a new release, the canary deployment is updated, but the primary is not, and the canary succeeds. I have pods running with old specs and crashed, which were promoted to primary in the past. As the primary deployment is not updated, no updated pods are updated. This is because of #362.

I can't solve this unless I manually remove the whole canary structure, which seems stuck.

@stefanprodan
Copy link
Member

Hi @giggio what provider are you using?

@stefanprodan stefanprodan added the kind/bug Something isn't working label Nov 25, 2019
@giggio
Copy link
Author

giggio commented Nov 25, 2019

Hey @stefanprodan, we are using Istio.

@stefanprodan
Copy link
Member

Can you please update Flagger image to weaveworks/flagger:skip-primary-check-9af6ade you should be able to rollout the new version with skip analysis on even if the primary fails. Please let me know if it worked. Thanks!

@stefanprodan
Copy link
Member

Also please join Flagger slack channel and give me a ping https://slack.weave.works/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants