Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice: Seeking maintainer #363

Open
MarkOSullivan94 opened this issue May 24, 2022 · 30 comments
Open

Notice: Seeking maintainer #363

MarkOSullivan94 opened this issue May 24, 2022 · 30 comments

Comments

@MarkOSullivan94
Copy link
Collaborator

Hey all 👋

Looking to appoint someone to take over maintenance of flutter_launcher_icons, please comment if you wish to take over.

Thanks!
@MarkOSullivan94 MarkOSullivan94 pinned this issue May 24, 2022
@MarkOSullivan94 MarkOSullivan94 mentioned this issue May 24, 2022
Open
@RatakondalaArun
Copy link
Contributor

RatakondalaArun commented May 30, 2022 •
edited
Loading

Hi @MarkOSullivan94
I am interested in maintaining this project
I may not have much experience with native android and IOS development but I can help you guys with cleaning up the repository and do my part for the community.

@bradintheusa
Copy link

I'll volunteer. I'm a full-time flutter freelancer whos been using flutter since the beta. I have already taken over a few packages.

@MarkOSullivan94
Copy link
Collaborator Author

Hi @bradintheusa and @RatakondalaArun, thank you for reaching out and volunteering.

I would love it if both of you decide to help maintain flutter_launcher_icons.

I notice @RatakondalaArun has already submitted a PR #322 (thanks for adding the closing keywords to auto close the related issues / PRs ❤️ ), @bradintheusa can you review this and if all good we can merge in, if there's anything else needed before next release then we can add that in too.

Perhaps it would be good to co-ordinate a plan of action going forward on what needs addressing next, what do you two think?

@bradintheusa
Copy link

Sounds like a good plan to me.

@bradintheusa
Copy link

Looks good, there's a space missing at the end of the error. But we can patch that.

Cannot not find minSdk from android/app/build.gradle or android/local.propertiesSpecify minSdk in either android/app/build.gradle or android/local.properties

@bradintheusa
Copy link

I'm quite ok to keep on top of the issues and provide support. I can also update the documentation/examples as needed.

@MarkOSullivan94
Copy link
Collaborator Author

Thanks for reviewing @bradintheusa, I've merged in now.

Anything either of you two @RatakondalaArun or @bradintheusa want to include before new version is released?

@RatakondalaArun
Copy link
Contributor

I think we can fix #350 as well

@bradintheusa
Copy link

Agreed with #350 then it would be nice to push a version out to show some activity.

@bradintheusa
Copy link

After the release, I can triage the open issues and remaining PR.

@MarkOSullivan94
Copy link
Collaborator Author

MarkOSullivan94 commented Jun 6, 2022 •
edited
Loading

I've opened a PR to fix #350: #364

Going forward it might be nice to adopt Conventional Commits - I know Melos has a tool which automatically generates changelogs if conventional commits are used

I've also given @RatakondalaArun write access to the repo and @bradintheusa triage access, Brad if you are wanting write access then I can increase the access.

@bradintheusa
Copy link

I like the Conventional Commits idea.

@bradintheusa
Copy link

I'll start Triage, if they are old and vague I'll close them. Otherwise, I'll update them to see if I can get more information / reproduce them.

@MarkOSullivan94
Copy link
Collaborator Author

Thank you @RatakondalaArun and @bradintheusa for your reviews and contributions, thanks to you both v0.9.3 is now published 🎉

@RatakondalaArun
Copy link
Contributor

@MarkOSullivan94 I am wondering how is the package deployment happening? I don't see any CD pipeline in place

@MarkOSullivan94
Copy link
Collaborator Author

@MarkOSullivan94 I am wondering how is the package deployment happening? I don't see any CD pipeline in place

Right now there's no CD in place @RatakondalaArun, whenever a new version is needing to be published, I run the publish command on my local terminal.

It's not something I had considered doing in the past but looking at this blog post it seems that we could trigger a new release to be published to pub whenever a new tag starting with v is created which would reduce the manual effort required to get new versions shipped and especially useful during times weren't it's hard to reach me.

@MarkOSullivan94 MarkOSullivan94 mentioned this issue Jun 19, 2022
Closed
@RatakondalaArun
Copy link
Contributor

Hi @MarkOSullivan94 and @bradintheusa

I think it would be very helpful if we start implementing support for stable platforms MacOS, Windows, Linux, and Web.
We do already have PR's for most of the platforms except Linux.

MacOS:

Windows:

Linux:

  • No PR's

Web:

What you guys think?

@bradintheusa
Copy link

!00% agree. It seems like it would be easy & popular.

@RatakondalaArun
Copy link
Contributor

Hi @MarkOSullivan94, @bradintheusa

I am thinking about restructuring flutter_icons_config.yaml format

current config

flutter_icons:
  image_path: "assets/images/icon-128x128.png"
  image_path_android: "assets/images/icon-710x599-android.png"
  image_path_ios: "assets/images/icon-1024x1024.png"
  android: true # can specify file name here e.g. "ic_launcher"
  ios: true # can specify file name here e.g. "My-Launcher-Icon"
  adaptive_icon_background: "assets/images/christmas-background.png" # only available for Android 8.0 devices and above
  adaptive_icon_foreground: "assets/images/icon-foreground-432x432.png" # only available for Android 8.0 devices and above
  # if I add support for web
  web: true
  image_path_web: "path/to/web.png"
  background_color_web: "#hexcolor"
  theme_color_web: "#hexcolor"
  # if we add support for linux
  linux true
  image_path_linux: "path/to/image.png"
  #if we add support for windows
  windows: true
  image_path_windows: true
  # ... and so on with other platforms

My suggestion

image_path: "path/to/image.png" # fallback if not specified for platform
android:
  generate: true # specifies weather to generate icons for this platform or not
  image_path: "path/to/image.png"
  adaptive_icon_background: "path/to/image.png"
  adaptive_icon_foreground: "path/to/image.png"
ios:
  generate: true
  image_path: "path/to/image.png"
web:
  generate: true
  image_path: "path/to/image.png"
  background_color: "#hexcode"
  theme_color: "#hexcode"
linux:
  generate: true
  image_path: "path/to/image.png"
windows:
  generate: true
  image_path: "path/to/image.png"
macos:
 generate: true
 image_path: "path/to/image.png"

What this will bring to the table?

  • better organized configs
  • easy to maintain
  • we can also use checked_yaml to add static support

Let me know what you guys think

@bradintheusa
Copy link

I like it. It's much nicer

@MarkOSullivan94
Copy link
Collaborator Author

Hi @MarkOSullivan94 and @bradintheusa

I think it would be very helpful if we start implementing support for stable platforms MacOS, Windows, Linux, and Web. We do already have PR's for most of the platforms except Linux.

MacOS:

Windows:

Linux:

  • No PR's

Web:

What you guys think?

Definitely a good idea! Just a heads up, I remember taking a look at the conflicts of one of these PRs in the past and quickly realised it was not going to be a quick fix, instead of taking on the effort of resolving the conflict it might be better to identify what is needed to support the new platform, create a new branch and go from there.

@MarkOSullivan94
Copy link
Collaborator Author

Hi @MarkOSullivan94, @bradintheusa

I am thinking about restructuring flutter_icons_config.yaml format

current config

flutter_icons:
  image_path: "assets/images/icon-128x128.png"
  image_path_android: "assets/images/icon-710x599-android.png"
  image_path_ios: "assets/images/icon-1024x1024.png"
  android: true # can specify file name here e.g. "ic_launcher"
  ios: true # can specify file name here e.g. "My-Launcher-Icon"
  adaptive_icon_background: "assets/images/christmas-background.png" # only available for Android 8.0 devices and above
  adaptive_icon_foreground: "assets/images/icon-foreground-432x432.png" # only available for Android 8.0 devices and above
  # if I add support for web
  web: true
  image_path_web: "path/to/web.png"
  background_color_web: "#hexcolor"
  theme_color_web: "#hexcolor"
  # if we add support for linux
  linux true
  image_path_linux: "path/to/image.png"
  #if we add support for windows
  windows: true
  image_path_windows: true
  # ... and so on with other platforms

My suggestion

image_path: "path/to/image.png" # fallback if not specified for platform
android:
  generate: true # specifies weather to generate icons for this platform or not
  image_path: "path/to/image.png"
  adaptive_icon_background: "path/to/image.png"
  adaptive_icon_foreground: "path/to/image.png"
ios:
  generate: true
  image_path: "path/to/image.png"
web:
  generate: true
  image_path: "path/to/image.png"
  background_color: "#hexcode"
  theme_color: "#hexcode"
linux:
  generate: true
  image_path: "path/to/image.png"
windows:
  generate: true
  image_path: "path/to/image.png"
macos:
 generate: true
 image_path: "path/to/image.png"

What this will bring to the table?

  • better organized configs
  • easy to maintain
  • we can also use checked_yaml to add static support

Let me know what you guys think

Looks cleaner and more organised, I'm a fan! 👍

@RatakondalaArun RatakondalaArun mentioned this issue Jul 8, 2022
Open
@mrquantumoff mrquantumoff mentioned this issue Feb 21, 2023
Merged
@wolfgang254
Copy link

I'm having problem building a flutter app to APK can I get help please

@vlazdra
Copy link
Contributor

vlazdra commented Jul 19, 2023

Hey guys, is this package still requesting maintainers? I see the activity has been on the low and there are some useful PR's out there waiting to get merged.

Are you still maintaining this package or are you looking into new maintainers? @MarkOSullivan94 @bradintheusa

@MarkOSullivan94
Copy link
Collaborator Author

@vlazdra more help is always appreciated

@FeodorFitsner
Copy link

Have you found maintainer? It's been 7 months since the last package update. I'd like to add some new features like generating LaunchImage for iOS. Should I submit PR or fork the project?

@MarkOSullivan94
Copy link
Collaborator Author

MarkOSullivan94 commented Dec 4, 2023 •
edited
Loading

Have you found maintainer? It's been 7 months since the last package update. I'd like to add some new features like generating LaunchImage for iOS. Should I submit PR or fork the project?

We've had some maintainers help out and quite often we have amazing Flutter community members helping out by replying to reported issues.

I believe the LaunchImage is out of scope for flutter_launcher_icons and is more appropriate for a separate package

Does this package cover the functionality you are seeking @FeodorFitsner? https://pub.dev/packages/flutter_native_splash

@FeodorFitsner
Copy link

Didn't know about flutter_native_splash package, thanks for the tip! Looks like it's what we need. Thought modifying splash screen images should be a part of launcher_icons package. Anyway, if you need a help with flutter_launcher_icons project I can help.

@ManuelRauber
Copy link

@MarkOSullivan94 Is there an update for the maintainer search? I think this package needs some love.

@maxfrees
Copy link

https://pub.dev/packages/icons_launcher

@MarkOSullivan94 MarkOSullivan94 unpinned this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ManuelRauber @bradintheusa @FeodorFitsner @vlazdra @MarkOSullivan94 @RatakondalaArun @wolfgang254 @maxfrees