Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Flutter Downloader 2.0 #550

Closed
wants to merge 1 commit into from
Closed

[WIP] Flutter Downloader 2.0 #550

wants to merge 1 commit into from

Conversation

hnvn
Copy link
Member

@hnvn hnvn commented Oct 8, 2021

The changes of external storage APIs in Android 11 cause some problems with the current implementation. App can no longer create dedicated or app-specific directories with external storage so that savedDir is broken and becomes confused.

This PR will focus on following tasks:

  • Re-design enqueue() API with new strategy to manage download location.
  • Support new metadata field in built-in SQLite database that helps developers store additional data for download tasks. (see Add another column to your DB table #195)

@hnvn
Copy link
Member Author

hnvn commented Oct 8, 2021

It is the very beginning to think about a new strategy to manage download file location. Storage Access APIs is very different among Android and iOS, even in different versions of Android. I am thinking of breaking down savedDir parameter into platform-specific 🤔

Welcome discussion about this topic

@kuhnroyal
Copy link

#277 is very important to keep in mind.

@azeek
Copy link

azeek commented Nov 11, 2021

#332
Don't forget this.
Concurrent download limit does not work on ios.

Please consider porting each platform language of the plugin from Java to Kotlin and from obj-c to swift.

@838
Copy link
Contributor

838 commented Nov 18, 2021

#500 and #437 🤘

@jmshrv
Copy link
Contributor

jmshrv commented Nov 21, 2021

It'd also be awesome to see #283, although it looks like it hasn't been worked on in a while

@jmshrv
Copy link
Contributor

jmshrv commented Dec 15, 2021

It would be useful to be able to pass platform-specific URLs since that's what iOS/Android seem to want, and it looks like file_picker can return the native URL for files (and I may make a PR to add returning URLs for directories).

@drahmedgabr
Copy link

Hello ..
My app path is emulated/0/Documents/MyApp
this is ok with Android 11 but plugin force download to Downloads folder
how to change this?

@ABDERRAHMANE-OUALI
Copy link

@drahmedgabr You can use use Dio and Path Provider as alternative, with Dio package you can download files from url fairly simply with one line of code, but you have to implement the loader indicator your self

@drahmedgabr
Copy link

@ABDERRAHMANE-OUALI Thanks bro .. you helped me so much .. جزاكم الله كل خير

@ABDERRAHMANE-OUALI
Copy link

@drahmedgabr np

@Faaatman
Copy link

Hello, @hnvn hope you're doing great! Is there any news about the metadata column?
Thanks!

@hnvn
Copy link
Member Author

hnvn commented Apr 25, 2022

@Faaatman , I am quite busy now, not sure about time that I can work on this PR.

@bartekpacia bartekpacia deleted the v2.0 branch May 23, 2022 10:04
@bartekpacia
Copy link
Collaborator

bartekpacia commented May 23, 2022

Closing because not much work has been done here, but lots of good ideas. I referenced this PR in #639 so these ideas are not lost :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants