Add Korean localization #494
Conversation
|
@LeGoffMael Can you help review the language? |
|
I think the translation is good and also it uses the proper language code |
Co-authored-by: Maël <[email protected]>
| const KoreanAssetPickerTextDelegate(); | ||
|
|
||
| @override | ||
| String get languageCode => 'kr'; |
There was a problem hiding this comment.
kr stands for Kanuri? This should be ko?
There was a problem hiding this comment.
In Korea, I used 'kr' more often and used the code, but I changed it to 'ko' following the review!
There was a problem hiding this comment.
I'm not sure you'll get the Korean localization if you put Locale('kr') in Flutter. Can you identify that?
There was a problem hiding this comment.
Yes, but based on the comment LeGoffMael wrote, it looks better to apply it as 'ko'
|
Could you also test with TalkBack/VoiceOver and provide a corresponding screen recording (with the accessibility speaker sound)? This will make sure sentences make sense when reading for disabled people. |
|
I've never used the TalkBack/VoiceOver, so the movement might be awkward. is it okay? RPReplay_Final1695272629.mov33c92dc3a5b0a523febc.1.mp4 |
@LeGoffMael Could you verify if the sentences are appropriate in screen recordings? |
Since @LIMMIHEE shared a screen recording from an iPhone, here is how it looked like on an android. It seems good to me XRecorder_27092023_011342.mp4 |
|
@all-contributors Add @LIMMIHEE for translation, add @LeGoffMael for translation. |
|
I've put up a pull request to add @LIMMIHEE! 🎉 |
Adds @LIMMIHEE as a contributor for translation. This was requested by AlexV525 [in this comment](#494 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Hi
I want Korean support, but in the case of the existing Pull Request, the process has been stopped since then, so I will improve the sentence more naturally and request it again.
please review it.
Thank you.
Test.Recording13.40.49.mp4