Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Camera Example Plugin Apps Targetsdk Versions #8193

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Nov 27, 2024

Bumped targetsdk versions of example app plugins for camera, camera_android, and camera_android_camerax. Deleted Capture specific image resolutions integration. The Android CameraX team confirmed the result coming from the CameraX side is correct and works as they expect. This means the supported output sizes cannot fulfill our test case assumptions.

For 'camera_android_camerax', we use the automatic selection described here, and it willl automatically choose, so we can't control the outcome. Even if we specify, the resolution is not gauranteed.

camera would have the same behavior as camera_android_camerax because camera's android implementation defaults to camera_android_camerax behavior.

For camera_android we cannot choose the aspect ratio here. If there's an unsupported size, it "falls through" to the next smallest size, which means we cannot choose the final resolution. Example high quality aspect ratio here, and logic for final resolution here.

Fixes flutter/flutter#154682

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jesswrd jesswrd force-pushed the i154682-bump-camera-sdk-versions branch from ff84ce5 to cce3ce2 Compare December 10, 2024 00:07
@jesswrd jesswrd added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Dec 10, 2024
@jesswrd jesswrd changed the title [WIP] Bump Camera Example Plugin Apps Targetsdk Versions Bump Camera Example Plugin Apps Targetsdk Versions Dec 10, 2024
@jesswrd jesswrd marked this pull request as ready for review December 10, 2024 21:03
@jesswrd jesswrd marked this pull request as draft December 10, 2024 21:04
@jesswrd jesswrd marked this pull request as ready for review December 10, 2024 21:31
@jesswrd jesswrd requested a review from reidbaker December 10, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camera_android and camera_android_camerax integration tests failure on image resolution
1 participant