-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Camera Example Plugin Apps Targetsdk Versions #8193
Open
jesswrd
wants to merge
10
commits into
flutter:main
Choose a base branch
from
jesswrd:i154682-bump-camera-sdk-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a139e90.
jesswrd
force-pushed
the
i154682-bump-camera-sdk-versions
branch
from
December 10, 2024 00:07
ff84ce5
to
cce3ce2
Compare
jesswrd
added
override: no versioning needed
Override the check requiring version bumps for most changes
override: no changelog needed
Override the check requiring CHANGELOG updates for most changes
labels
Dec 10, 2024
jesswrd
changed the title
[WIP] Bump Camera Example Plugin Apps Targetsdk Versions
Bump Camera Example Plugin Apps Targetsdk Versions
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
override: no changelog needed
Override the check requiring CHANGELOG updates for most changes
override: no versioning needed
Override the check requiring version bumps for most changes
p: camera
platform-android
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped targetsdk versions of example app plugins for
camera
,camera_android
, andcamera_android_camerax
. DeletedCapture specific image resolutions
integration. The Android CameraX team confirmed the result coming from the CameraX side is correct and works as they expect. This means the supported output sizes cannot fulfill our test case assumptions.For 'camera_android_camerax', we use the automatic selection described here, and it willl automatically choose, so we can't control the outcome. Even if we specify, the resolution is not gauranteed.
camera
would have the same behavior ascamera_android_camerax
becausecamera
's android implementation defaults tocamera_android_camerax
behavior.For
camera_android
we cannot choose the aspect ratio here. If there's an unsupported size, it "falls through" to the next smallest size, which means we cannot choose the final resolution. Example high quality aspect ratio here, and logic for final resolution here.Fixes flutter/flutter#154682
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.