-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Check repo-level package metadata #5811
Merged
auto-submit
merged 17 commits into
flutter:main
from
stuartmorgan:tool-package-repo-info-check
Jan 12, 2024
Merged
[ci] Check repo-level package metadata #5811
auto-submit
merged 17 commits into
flutter:main
from
stuartmorgan:tool-package-repo-info-check
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good besides this typo
stuartmorgan
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jan 12, 2024
auto-submit
bot
removed
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jan 12, 2024
auto label is removed for flutter/packages/5811, due to - The status or check suite Linux_android android_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jan 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2024
flutter/packages@0744fe6...d74d687 2024-01-12 [email protected] [ci] Check repo-level package metadata (flutter/packages#5811) 2024-01-12 [email protected] [various] Add iOS privacy manifests (flutter/packages#5846) 2024-01-11 [email protected] [video_player] Skip flaky tests in certain circumstances on Android (flutter/packages#5872) 2024-01-11 [email protected] Roll Flutter (stable) from 78666c8 to 46787ee (5 revisions) (flutter/packages#5870) 2024-01-11 [email protected] Roll Flutter from b840a60 to 9f2e681 (24 revisions) (flutter/packages#5871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
sybrands-place
pushed a commit
to sybrands-place/packages
that referenced
this pull request
Jan 16, 2024
* main: (186 commits) Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter#5895) [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default (flutter#5723) Roll Flutter (stable) from 46787ee49c1f to ef1af02aead6 (1 revision) (flutter#5887) [google_maps_flutter] Drop iOS 11 support (flutter#5873) Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter#5882) [ci] Check repo-level package metadata (flutter#5811) [various] Add iOS privacy manifests (flutter#5846) [video_player] Skip flaky tests in certain circumstances on Android (flutter#5872) Roll Flutter (stable) from 78666c8dc57e to 46787ee49c1f (5 revisions) (flutter#5870) Roll Flutter from b840a60 to 9f2e681 (24 revisions) (flutter#5871) [quick_actions_android] Close system dialogs for integration test (flutter#5853) [file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter#5712) [in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5713) [url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter#5708) [image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter#5703) Roll Flutter from 126302d to b840a60 (29 revisions) (flutter#5855) Roll Flutter from c6ddb73 to 126302d (32 revisions) (flutter#5852) Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter#5849) Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter#5841) [ci] Exclude quick_actions from Android emulators (flutter#5847) ... # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Adds a new tool command (and runs it in CI) to check that each package: - is listed correctly in the repo-level README.md table - has a CODEOWNERS entry In the future we could add other things (e.g., auto-label), but these were the main things we've had issues with recently. Updates README.md and CODEOWNERS to fix failures it found: - Adds a couple of missing CODEOWNERS - Expands the web implementation CODEOWNERS to individual packages so that we don't have to special-case handling in the tool - Fixes some minor mistakes in README.md - URL-encodes all `:`s in the README.md links (which is why ever line shows as changed); it worked without that in practice, but it should really be encoded, and having it consistently encoded made things easier for the tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new tool command (and runs it in CI) to check that each package:
In the future we could add other things (e.g., auto-label), but these were the main things we've had issues with recently.
Updates README.md and CODEOWNERS to fix failures it found:
:
s in the README.md links (which is why ever line shows as changed); it worked without that in practice, but it should really be encoded, and having it consistently encoded made things easier for the tooling.