From 54dd8883c5cfeea69e1be1383c091a5e90dfb34b Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 25 Sep 2024 10:39:02 -0700 Subject: [PATCH] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (#7688) This PR removes three const lints from package:flutter_lints: `prefer_const_constructors`, `prefer_const_declarations`, and `prefer_const_literals_to_create_immutables`. This PR does not rev the pubspec version. We want to stage this change out in coordination with package:lints; see https://github.com/dart-lang/lints/issues/209. - https://github.com/dart-lang/lints/issues/205 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests --- packages/flutter_lints/CHANGELOG.md | 4 ++++ packages/flutter_lints/lib/flutter.yaml | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/flutter_lints/CHANGELOG.md b/packages/flutter_lints/CHANGELOG.md index 27b4f0088b9e..e2ed68619b5e 100644 --- a/packages/flutter_lints/CHANGELOG.md +++ b/packages/flutter_lints/CHANGELOG.md @@ -1,5 +1,9 @@ ## NEXT +* Removed the following lints: + * `prefer_const_constructors` (see https://github.com/dart-lang/lints/issues/205) + * `prefer_const_declarations` + * `prefer_const_literals_to_create_immutables` * Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. ## 4.0.0 diff --git a/packages/flutter_lints/lib/flutter.yaml b/packages/flutter_lints/lib/flutter.yaml index bcad70fc1087..8c108e2b5b44 100644 --- a/packages/flutter_lints/lib/flutter.yaml +++ b/packages/flutter_lints/lib/flutter.yaml @@ -8,10 +8,7 @@ linter: - avoid_unnecessary_containers - avoid_web_libraries_in_flutter - no_logic_in_create_state - - prefer_const_constructors - prefer_const_constructors_in_immutables - - prefer_const_declarations - - prefer_const_literals_to_create_immutables - sized_box_for_whitespace - sort_child_properties_last - use_build_context_synchronously