Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow iOS unit tests to run on Xcode 13 #27850

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Allow iOS unit tests to run on Xcode 13 #27850

merged 1 commit into from
Aug 2, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 2, 2021

  1. Allow tests to run on Xcode 13 by remove any major version check, just make sure Xcode is installed.
  2. Fix python3 TypeError: cannot use a string pattern on a bytes-like object error by matching the Regex by bytes.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Aug 2, 2021
@google-cla google-cla bot added the cla: yes label Aug 2, 2021
@jmagman jmagman requested a review from cbracken August 2, 2021 21:07
cbracken
cbracken approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 2, 2021
@fluttergithubbot fluttergithubbot merged commit 76382d5 into flutter:master Aug 2, 2021
@jmagman jmagman deleted the run-ios-unit-tests branch August 2, 2021 21:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
76382d5 Allow iOS unit tests to run on Xcode 13 (flutter/engine#27850)
eaafe15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
@engine-flutter-autoroll
76382d5 Allow iOS unit tests to run on Xcode 13 (flutter/engine#27850)
a387a52
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@jmagman
Allow iOS unit tests to run on Xcode 13 (flutter#27850)
1074b71
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@jmagman @filmil
Allow iOS unit tests to run on Xcode 13 (flutter#27850)
2ee4bbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

@jmagman jmagman

Labels
cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @cbracken @fluttergithubbot