Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a4f266f7eb1a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1c4e5e230ecb
Choose a head ref
  • 8 commits
  • 47 files changed
  • 5 contributors

Commits on Jun 17, 2024

  1. Roll Skia from 0dda1054f543 to 2b9bc16df969 (1 revision) (#53431)

    https://skia.googlesource.com/skia.git/+log/0dda1054f543..2b9bc16df969
    
    2024-06-17 [email protected] [graphite] Add sk_hw_yuv_image_shader.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 17, 2024
    Copy the full SHA
    0641087 View commit details
  2. [flatland] Handle fence overflow in flatland_connection.cc (#53366)

    flatland_connection.cc used to allow an arbitrary number of acquire and release fences to be scheduled for each frame.
    
    Sadly, Fuchsia has a limitation of (1) the number of total handles that can be sent per a FIDL call, but also (2) the Flatland protocol only supports sending up to 16 fences per each fence type.
    
    Now, normally there should be very few scheduled fences per frame. But if frames get skipped, we could amass many fences which would then crash our attempts to send all of them to the Flatland `Present` endpoint.
    
    This change introduces two fence multiplexer, which allow us to signal more than 16 fences per type, at a performance penalty. We expect to be able *not* to crash the FIDL subsystem using this approach, and may even be able to hobble along for a bit, until the fences issue is hopefully self-resolved.
    
    That said, this issue seems to indicate there are frame scheduling problems elsewhere. But this is a fairly straightforward change to make without affecting the rest of the flatland code or integration, so we opt to do that first.
    
    Issues: [#150136](#53366)
    
    - [] I updated/added relevant documentation (doc comments with `///`).
    filmil authored Jun 17, 2024
    Copy the full SHA
    cabc195 View commit details
  3. [Impeller] Move drawAtlas golden tests to display list. (#53398)

    Part of flutter/flutter#142054
    
    Moves all of the drawAtlas tests for aiks and entities into DL. This might change some of the entity goldens but ... these are easy to eyeball so it should be fine IMO.
    jonahwilliams authored Jun 17, 2024
    Copy the full SHA
    dec5f63 View commit details
  4. Roll Dart SDK from 1ce6b4d54247 to 51bbba0da7d3 (1 revision) (#53432)

    https://dart.googlesource.com/sdk.git/+log/1ce6b4d54247..51bbba0da7d3
    
    2024-06-17 [email protected] Version 3.5.0-271.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 17, 2024
    Copy the full SHA
    fd9eb04 View commit details
  5. Copy the full SHA
    8a8f285 View commit details
  6. [Impeller] move draw vertices to dl unittests. (#53400)

    Part of flutter/flutter#142054
    
    Moves all of the drawVertices tests for aiks and entities into DL. This might change some of the entity goldens but ... these are easy to eyeball so it should be fine IMO.
    jonahwilliams authored Jun 17, 2024
    Copy the full SHA
    9407053 View commit details
  7. [Impeller] Update Android CPU profiling instructions. (#53437)

    * Highlighting the section that says you can profile using a blank project. This saved me as I couldn't find the Profiler anywhere in the project for the Wondrous app.
    * Added a section that shows how you can mark a release app as debuggable.
    * Added tooltips for images.
    * Cleanups for readability (subjective).
    chinmaygarde authored Jun 17, 2024
    Copy the full SHA
    c5e0e55 View commit details
  8. [DisplayList] Create DrawDashedLine for paragraph code (#53411)

    With this minor addition to the DlCanvas/DisplayList API the code in the paragraph builder no longer needs to worry about PathEffect objects and their varying support on the backends.
    
    At this point all PathEffect code in the engine is obsolete and can be deleted, but I'll leave that for a follow-on PR.
    
    The only PathEffect related thing I did delete was support for rendering primitives with a PathEffect in the DL Rendering tests, both because it is a vestigial attribute and also because it would interfere with the new DrawDashedLine rendering test (a PathEffect on top of a PathEffect...).
    flar authored Jun 17, 2024
    Copy the full SHA
    1c4e5e2 View commit details
Loading