From d671b2d3e43a3ed18c4be5056c39531d582f139d Mon Sep 17 00:00:00 2001 From: Kevin Lubick Date: Mon, 11 Sep 2023 13:55:05 -0400 Subject: [PATCH] Update skwasm build to use safer flush call (#45652) Follow-up to https://github.com/flutter/engine/pull/45644 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- lib/web_ui/skwasm/surface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/web_ui/skwasm/surface.cpp b/lib/web_ui/skwasm/surface.cpp index 8497b18ef55a3..f1601bbef976c 100644 --- a/lib/web_ui/skwasm/surface.cpp +++ b/lib/web_ui/skwasm/surface.cpp @@ -148,7 +148,7 @@ void Surface::_renderPicture(const SkPicture* picture, uint32_t callbackId) { auto canvas = _surface->getCanvas(); canvas->drawColor(SK_ColorTRANSPARENT, SkBlendMode::kSrc); canvas->drawPicture(sk_ref_sp(picture), &matrix, nullptr); - _grContext->flush(_surface); + _grContext->flush(_surface.get()); skwasm_captureImageBitmap(this, _glContext, callbackId, roundedOutRect.width(), roundedOutRect.height()); }