Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev bump workflow should not run when we are not already on a dev version #6137

Closed
kenzieschmoll opened this issue Aug 1, 2023 · 3 comments · Fixed by #6157
Closed

Dev bump workflow should not run when we are not already on a dev version #6137

kenzieschmoll opened this issue Aug 1, 2023 · 3 comments · Fixed by #6157
Assignees
@CoderDake
Labels
infra P2 important to work on, but not at the top of the work list.

Comments

@kenzieschmoll
Copy link
Member

This PR is an example of the dev bump workflow bot behaving poorly right after a release: 8ec8a22.

The correct move would have been to go from 2.26.0 to 2.27.0-dev.0, but the workflow mistakenly changed from 2.26.0 to 2.26.0-dev.0.
@kenzieschmoll kenzieschmoll added infra P2 important to work on, but not at the top of the work list. labels Aug 1, 2023
@kenzieschmoll
Copy link
Member Author

another example of an incorrect bump: #6142

@CoderDake
Copy link
Contributor

@kenzieschmoll The assumption is that this step is done manually as part of the release process.
https://github.com/flutter/devtools/blob/master/tool/RELEASE_INSTRUCTIONS.md#update-to-the-next-version

This can be quickly done by running the command in the above step.

I can definitely add a check to make sure that nothing happens when we find ourselves in this case though.

@kenzieschmoll
Copy link
Member Author

short circuiting the workflow if we find ourself in that state sgtm

@CoderDake CoderDake mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoderDake CoderDake

Labels
infra P2 important to work on, but not at the top of the work list.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for dev bumps to protect release versions flutter/devtools
2 participants
@CoderDake @kenzieschmoll