Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service extension methods should be cleared between app connections #5958

Closed
elliette opened this issue Jun 26, 2023 · 1 comment · Fixed by #5960
Closed

Service extension methods should be cleared between app connections #5958

elliette opened this issue Jun 26, 2023 · 1 comment · Fixed by #5960
Assignees

Comments

@elliette
Copy link
Member

The "registered methods for service" for hot restart are: [s0.hotRestart, hotRestart, hotRestart]

We call the first one which is s0.hotRestart, which is unrecognized. Calling just hotRestart is recognized however.

Code link:

final registered = _registeredMethodsForService[name] ?? const [];
if (registered.isEmpty) {
throw Exception('There are no registered methods for service "$name"');
}
return service!.callMethod(
registered.first,

@elliette
Copy link
Member Author

Ah this only happens if we have connect an existing DevTools to a new application. In this case I had DevTools connected to a macos app, I disconnected from that app, then I reconnected to a chrome app. The registered service extensions should be cleared when a new app is connected, otherwise we'll still be trying to use the old service extension names.

@elliette elliette changed the title Hot restart is broken on web Service extension methods should be cleared between app connections Jun 26, 2023
@elliette elliette self-assigned this Jun 26, 2023
@polina-c polina-c added the P4 label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants