Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Export (or Save/Open) should be discoverable and consistent #4645

Closed
polina-c opened this issue Oct 27, 2022 · 12 comments · Fixed by #6567
Closed

Import/Export (or Save/Open) should be discoverable and consistent #4645

polina-c opened this issue Oct 27, 2022 · 12 comments · Fixed by #6567
Assignees
Labels
fix it friday offline P2 important to work on, but not at the top of the work list. ux

Comments

@polina-c
Copy link
Contributor

polina-c commented Oct 27, 2022

Problems:

  1. It is now called Import/Export and should be Open/Save
  2. Drag and drop for import is not discoverable
  3. Memory page has different implementation

Mindy:
needs afforances for drag and drop and import button. "Export" might be the wrong word here if the main user journey is to save and reload states within the DevTools. "Save" and "Open" might be more appropriate. Even better if on save the user can name the file and the directory is shown so they know where to find it for sharing with others. -Mindy

Mindy / Polina (2022-10-21 11:39 GMT-7) at 4:15

@polina-c polina-c added the ux label Oct 27, 2022
@CoderDake CoderDake added the P4 label Oct 27, 2022
@kenzieschmoll
Copy link
Member

kenzieschmoll commented Oct 31, 2022

Switching to Open / Save SGTM. This should be a simple change, we already have the file selector plugin hooked up in other parts of DevTools.

@polina-c
Copy link
Contributor Author

How about discoverability of 'Open' with drag and drop? Do we want to continue supporting it? If yes, we need to figure out how to make it discoverable.
But may be it will be better to reserve drag and drop for other more important future features that may take advantage of it?

@kenzieschmoll
Copy link
Member

It doesn't cost us any overhead to leave the Drag and drop functionality there. We can leave it here for users who are used to it and would not like if it was ripped out, and we can point all new users to use the Save / Open buttons.

@polina-c
Copy link
Contributor Author

And, we can suggest to drag and drop in the tooltip for the button 'Open'.

@bkonyi
Copy link
Contributor

bkonyi commented Nov 1, 2022

we already have the file selector plugin hooked up in other parts of DevTools.

I didn't think we had a file selector plugin that worked on web, or am I mistaken?

@polina-c
Copy link
Contributor Author

polina-c commented Nov 1, 2022

We have it. See for example App Size > Import File

@polina-c
Copy link
Contributor Author

polina-c commented Nov 1, 2022

The tooltips for the buttons can be:

  • Save the screen state to the folder Download, to open or share later.
  • Open a previously saved screen.

@melyndahoover
@MaryaBelanger

How does it look?

@MaryaBelanger
Copy link

Save the screen state to the folder Download, to open or share later.

Change to:

Save the screen state to the Downloads folder

Save's original is a little long for a tooltip. Plus the buttons are logically paired (and I'm assuming graphically paired as well), so Open's tooltip provides the same information

@melyndahoover
Copy link

Marya's suggestion for the save tooltip and Polina's suggestion for the open tooltip sound good to me.

@polina-c
Copy link
Contributor Author

polina-c commented Nov 4, 2022

This is how return back to online mode is implemented in CPU Profiler.
All other screens disappear, but CPU Profiler, and there is button 'Exit offline mode'.

Is it how we want it to be implemented for memory screen?

Screen Shot 2022-11-04 at 4 16 48 PM

@kenzieschmoll
Copy link
Member

I would recommend to keep this consistent for all DevTools pages. This makes it clear that we are in offline mode, viewing a single set of data, and to return to the "live" view of DevTools, the user would need to exit the offline mode.

@polina-c polina-c changed the title Import/Export (or Save/Open) should be consistent across the screens and usable Import/Export (or Save/Open) should be discoverable and consistent Dec 12, 2022
@kenzieschmoll kenzieschmoll added P2 important to work on, but not at the top of the work list. and removed P4 labels Jul 5, 2023
@kenzieschmoll
Copy link
Member

Instead of having the import action be accessible from the toolbar at all times, in static mode we should have the pages that support loading offline data be present, and on those pages we should just show an action to load offline data. This will make it more clear which pages support loading data and what kind of data can be imported. When we are connected to an app, each screen should have its own import (or after renaming, 'open') button where a user can still access the offline viewing mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix it friday offline P2 important to work on, but not at the top of the work list. ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants