Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide data type internals on the provider page #3004

Closed
kenzieschmoll opened this issue May 11, 2021 · 1 comment · Fixed by #3006
Closed

Hide data type internals on the provider page #3004

kenzieschmoll opened this issue May 11, 2021 · 1 comment · Fixed by #3006

Comments

@kenzieschmoll
Copy link
Member

In this example, we are exposing the internals of _CompactLinkedHashSet. Does exposing this data add any value for the user, and should we be allowing them to edit these values?

Screen Shot 2021-05-11 at 2 10 49 PM

@rrousselGit @jacob314

@rrousselGit
Copy link
Contributor

I have implemented the parsing to hide them.

I just haven't implemented the UI to actually do the hiding.
The main reason being I didn't see an existing styled Checkbox and didn't bother make one myself.

But I agree this would be valuable, although likely needs to be optional

@kenzieschmoll kenzieschmoll changed the title Should we be exposing data type internals on the provider page? Hide data type internals on the provider page May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants